Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Update instance_norm2 symbolic to handle track_running_stats=True (#55051) #58690

Closed
wants to merge 3 commits into from

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented May 20, 2021

Stack from ghstack:

Fixes #53887
Not input calling running_mean and running_var when track_running_stats=True

Co-authored-by: hwangdeyu deyhuang@qq.com

Differential Revision: D28714812

…rue (#55051)

Fixes [#53887](#53887)
Not input calling running_mean and running_var when track_running_stats=True

Co-authored-by: hwangdeyu <deyhuang@qq.com>

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 20, 2021

💊 CI failures summary and remediations

As of commit 1d50477 (more details on the Dr. CI page):


  • 8/8 failures possibly* introduced in this PR
    • 1/8 non-scanned failure(s)

7 failures not recognized by patterns:

Job Step Action
GitHub Actions Test tools / test Checkout PyTorch 🔁 rerun
GitHub Actions Windows CI (pytorch-win-vs2019-cpu-py3) / render_test_results Unknown 🔁 rerun
GitHub Actions Lint / cmakelint Unknown 🔁 rerun
GitHub Actions Lint / mypy Fetch PyTorch 🔁 rerun
GitHub Actions Lint / toc Checkout PyTorch 🔁 rerun
GitHub Actions Lint / clang-tidy Stop containers 🔁 rerun
GitHub Actions Lint / shellcheck Install Jinja2 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

…ing_stats=True (#55051)"

Fixes [#53887](#53887)
Not input calling running_mean and running_var when track_running_stats=True

Co-authored-by: hwangdeyu <deyhuang@qq.com>

[ghstack-poisoned]
@SplitInfinity
Copy link

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@SplitInfinity
Copy link

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…ing_stats=True (#55051)"


Fixes [#53887](#53887)
Not input calling running_mean and running_var when track_running_stats=True

Co-authored-by: hwangdeyu <deyhuang@qq.com>

Differential Revision: [D28714812](https://our.internmc.facebook.com/intern/diff/D28714812)

[ghstack-poisoned]
@SplitInfinity
Copy link

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@SplitInfinity merged this pull request in 51d14b6.

@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/72/head branch May 31, 2021 14:17
deniskokarev pushed a commit to deniskokarev/pytorch that referenced this pull request Jun 9, 2021
…rue (pytorch#55051) (pytorch#58690)

Summary:
Pull Request resolved: pytorch#58690

Fixes [pytorch#53887](pytorch#53887)
Not input calling running_mean and running_var when track_running_stats=True

Test Plan: Imported from OSS

Reviewed By: driazati

Differential Revision: D28714812

Pulled By: SplitInfinity

fbshipit-source-id: 3f2f2ec9a7eaf8a1432a552d751cbd5974b20195

Co-authored-by: hwangdeyu <deyhuang@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants