[ONNX] Enable support for roll() op. (#58389) #58582

BowenBao · 2021-05-19T18:16:08Z

Stack from ghstack:

[ONNX] Enable support for roll() op. (#58389) #58582 [ONNX] Enable support for roll() op. ([ONNX] Enable support for roll() op. #58389)
[ONNX] handle aten::_set_item on Dict in convertInplaceOpsAndTrackAlias (#58317) #58581 [ONNX] handle aten::_set_item on Dict in convertInplaceOpsAndTrackAlias ([ONNX] handle aten::_set_item on Dict in convertInplaceOpsAndTrackAlias #58317)
[ONNX] use consistent quoting for string literals (#57757) #58580 [ONNX] use consistent quoting for string literals ([ONNX] use consistent quoting for string literals #57757)
[ONNX] Improve lower tuples and handle control flow (#57650) #58579 [ONNX] Improve lower tuples and handle control flow ([ONNX] Improve lower tuples and handle control flow #57650)
[ONNX] Update special post process for SequenceInsert after SequenceEmpty (#56965) #58578 [ONNX] Update special post process for SequenceInsert after SequenceEmpty ([ONNX] Update special post process for SequenceInsert after SequenceEmpty #56965)
Support symbolic for conv_tbc (#58359) #58577 Support symbolic for conv_tbc (Support symbolic for conv_tbc #58359)
[ONNX] RNN scripting (#57564) #58576 [ONNX] RNN scripting ([ONNX] RNN scripting #57564)
[ONNX] Update instance_norm2 symbolic to handle track_running_stats=True (#55051) #58575 [ONNX] Update instance_norm2 symbolic to handle track_running_stats=True ([ONNX] Update instance_norm2 symbolic to handle track_running_stats=True #55051)

Add a symbolic function for aten::roll() op in symbolic_opset9.py.
Add a test with multiple scenarios as well.

Co-authored-by: fatcat-z jiz@microsoft.com

1. Add a symbolic function for aten::roll() op in symbolic_opset9.py. 2. Add a test with multiple scenarios as well. Co-authored-by: fatcat-z <jiz@microsoft.com> [ghstack-poisoned]

facebook-github-bot · 2021-05-19T18:16:25Z

💊 CI failures summary and remediations

As of commit 09d7ca7 (more details on the Dr. CI page):

2/3 failures introduced in this PR
1/3 broken upstream at merge base 691bcd1 on May 19 from 8:24am to 2:23pm

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_linux_bionic_py3_8_gcc9_coverage_test2 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 19 23:43:00 [E request_callback_no_python.c...g operation failed in the TorchScript interpreter.

May 19 23:43:00 
May 19 23:43:00 [E request_callback_no_python.cpp:667] Received error while processing request type 256: The following operation failed in the TorchScript interpreter.
May 19 23:43:00 Traceback of TorchScript (most recent call last):
May 19 23:43:00   File "/opt/conda/lib/python3.8/site-packages/torch/testing/_internal/distributed/rpc/rpc_test.py", line 340, in raise_func_script
May 19 23:43:00 @torch.jit.script
May 19 23:43:00 def raise_func_script(expected_err: str) -> torch.Tensor:
May 19 23:43:00     raise ValueError(expected_err)
May 19 23:43:00     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE
May 19 23:43:00 RuntimeError: Expected error
May 19 23:43:00 
May 19 23:43:00 [E request_callback_no_python.cpp:667] Received error while processing request type 256: The following operation failed in the TorchScript interpreter.
May 19 23:43:00 Traceback of TorchScript (most recent call last):
May 19 23:43:00   File "/opt/conda/lib/python3.8/site-packages/torch/testing/_internal/distributed/rpc/rpc_test.py", line 340, in raise_func_script
May 19 23:43:00 @torch.jit.script
May 19 23:43:00 def raise_func_script(expected_err: str) -> torch.Tensor:
May 19 23:43:00     raise ValueError(expected_err)
May 19 23:43:00     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE
May 19 23:43:00 RuntimeError: Expected error
May 19 23:43:00 
May 19 23:43:01 ok (3.776s)
May 19 23:43:05   test_wait_all_multiple_call (__main__.TensorPipeRpcTestWithSpawn) ... ok (3.881s)

1 failure not recognized by patterns:

Job	Step	Action
^{pytorch_linux_bionic_cuda10_2_cudnn7_py3_9_gcc7_test1}	^{Run tests}	🔁 rerun

1 job timed out:

pytorch_linux_bionic_py3_8_gcc9_coverage_test2

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

pytorch_linux_bionic_cuda10_2_cudnn7_py3_9_gcc7_test2 on May 19 from 8:24am to 2:23pm (4cf9b11 - 029bec4)
- 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

1. Add a symbolic function for aten::roll() op in symbolic_opset9.py. 2. Add a test with multiple scenarios as well. Co-authored-by: fatcat-z <jiz@microsoft.com> ghstack-source-id: ed3f0c01892e1b05bd07b5f7a45ee2edd62e83bc Pull Request resolved: #58582

[ONNX] Enable support for roll() op. (#58389)

09d7ca7

1. Add a symbolic function for aten::roll() op in symbolic_opset9.py. 2. Add a test with multiple scenarios as well. Co-authored-by: fatcat-z <jiz@microsoft.com> [ghstack-poisoned]

BowenBao requested review from neginraoof and spandantiwari as code owners May 19, 2021 18:16

facebook-github-bot added the cla signed label May 19, 2021

pytorchbot added the open source label May 19, 2021

BowenBao closed this May 20, 2021

facebook-github-bot deleted the gh/BowenBao/71/head branch June 20, 2021 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ONNX] Enable support for roll() op. (#58389) #58582

[ONNX] Enable support for roll() op. (#58389) #58582

BowenBao commented May 19, 2021 •

edited

Loading

facebook-github-bot commented May 19, 2021 •

edited

Loading

[ONNX] Enable support for roll() op. (#58389) #58582

[ONNX] Enable support for roll() op. (#58389) #58582

Conversation

BowenBao commented May 19, 2021 • edited Loading

facebook-github-bot commented May 19, 2021 • edited Loading

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

pytorch_linux_bionic_py3_8_gcc9_coverage_test2 (1/1)

1 failure not recognized by patterns:

🚧 1 fixed upstream failure:

BowenBao commented May 19, 2021 •

edited

Loading

facebook-github-bot commented May 19, 2021 •

edited

Loading