[ONNX] Improve lower tuples and handle control flow (#57650) #58579

BowenBao · 2021-05-19T18:15:48Z

Stack from ghstack:

[ONNX] Enable support for roll() op. (#58389) #58582 [ONNX] Enable support for roll() op. ([ONNX] Enable support for roll() op. #58389)
[ONNX] handle aten::_set_item on Dict in convertInplaceOpsAndTrackAlias (#58317) #58581 [ONNX] handle aten::_set_item on Dict in convertInplaceOpsAndTrackAlias ([ONNX] handle aten::_set_item on Dict in convertInplaceOpsAndTrackAlias #58317)
[ONNX] use consistent quoting for string literals (#57757) #58580 [ONNX] use consistent quoting for string literals ([ONNX] use consistent quoting for string literals #57757)
[ONNX] Improve lower tuples and handle control flow (#57650) #58579 [ONNX] Improve lower tuples and handle control flow ([ONNX] Improve lower tuples and handle control flow #57650)
[ONNX] Update special post process for SequenceInsert after SequenceEmpty (#56965) #58578 [ONNX] Update special post process for SequenceInsert after SequenceEmpty ([ONNX] Update special post process for SequenceInsert after SequenceEmpty #56965)
Support symbolic for conv_tbc (#58359) #58577 Support symbolic for conv_tbc (Support symbolic for conv_tbc #58359)
[ONNX] RNN scripting (#57564) #58576 [ONNX] RNN scripting ([ONNX] RNN scripting #57564)
[ONNX] Update instance_norm2 symbolic to handle track_running_stats=True (#55051) #58575 [ONNX] Update instance_norm2 symbolic to handle track_running_stats=True ([ONNX] Update instance_norm2 symbolic to handle track_running_stats=True #55051)

Improving the logic for finding tuple patterns within control flow.
Also fixes: #56914

Co-authored-by: neginraoof neginmr@utexas.edu

Improving the logic for finding tuple patterns within control flow. Also fixes: #56914 Co-authored-by: neginraoof <neginmr@utexas.edu> [ghstack-poisoned]

facebook-github-bot · 2021-05-19T18:16:00Z

💊 CI failures summary and remediations

As of commit bb72312 (more details on the Dr. CI page):

1/3 failures introduced in this PR
2/3 broken upstream at merge base ab07251 on May 19 from 8:24am to 2:23pm

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

Linux CI (pytorch-linux-xenial-py3.6-gcc5.4) / test (1/1)

Step: "Test PyTorch" (full log | diagnosis details | 🔁 rerun)

2021-05-19T20:10:40.3637190Z Build left local git repository checkout dirty

2021-05-19T20:10:34.5105037Z real	73m2.186s
2021-05-19T20:10:34.5105644Z user	127m23.442s
2021-05-19T20:10:34.5105915Z sys	27m20.495s
2021-05-19T20:10:34.5106223Z + assert_git_not_dirty
2021-05-19T20:10:34.5107278Z + [[ pytorch-linux-xenial-py3.6-gcc5.4 != *rocm* ]]
2021-05-19T20:10:34.5108454Z + [[ pytorch-linux-xenial-py3.6-gcc5.4 != *xla* ]]
2021-05-19T20:10:34.5109352Z ++ git status --porcelain
2021-05-19T20:10:40.3635095Z + git_status=' M third_party/tensorpipe'
2021-05-19T20:10:40.3635784Z + [[ -n  M third_party/tensorpipe ]]
2021-05-19T20:10:40.3636590Z + echo 'Build left local git repository checkout dirty'
2021-05-19T20:10:40.3637190Z Build left local git repository checkout dirty
2021-05-19T20:10:40.3637747Z + echo 'git status --porcelain:'
2021-05-19T20:10:40.3638197Z git status --porcelain:
2021-05-19T20:10:40.3638682Z + echo ' M third_party/tensorpipe'
2021-05-19T20:10:40.3639092Z  M third_party/tensorpipe
2021-05-19T20:10:40.3639408Z + exit 1
2021-05-19T20:10:40.3639682Z + cleanup
2021-05-19T20:10:40.3639954Z + retcode=1
2021-05-19T20:10:40.3640237Z + set +x
2021-05-19T20:10:40.3640580Z =================== sccache compilation log ===================
2021-05-19T20:10:40.3829258Z =========== If your build fails, please take a look at the log above for possible reasons ===========

🚧 2 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

pytorch_linux_bionic_cuda10_2_cudnn7_py3_9_gcc7_test2 on May 19 from 8:24am to 2:23pm (4cf9b11 - 029bec4)
- 🔁 rerun
pytorch_linux_bionic_cuda10_2_cudnn7_py3_9_gcc7_test1 on May 19 from 8:24am to 2:12pm (4cf9b11 - 029bec4)
- 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

[ONNX] Improve lower tuples and handle control flow (#57650)

bb72312

Improving the logic for finding tuple patterns within control flow. Also fixes: #56914 Co-authored-by: neginraoof <neginmr@utexas.edu> [ghstack-poisoned]

BowenBao requested review from neginraoof and spandantiwari as code owners May 19, 2021 18:15

facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue cla signed labels May 19, 2021

pytorchbot added the open source label May 19, 2021

BowenBao closed this May 20, 2021

facebook-github-bot deleted the gh/BowenBao/68/head branch June 20, 2021 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ONNX] Improve lower tuples and handle control flow (#57650) #58579

[ONNX] Improve lower tuples and handle control flow (#57650) #58579

BowenBao commented May 19, 2021 •

edited

Loading

facebook-github-bot commented May 19, 2021 •

edited

Loading

[ONNX] Improve lower tuples and handle control flow (#57650) #58579

[ONNX] Improve lower tuples and handle control flow (#57650) #58579

Conversation

BowenBao commented May 19, 2021 • edited Loading

facebook-github-bot commented May 19, 2021 • edited Loading

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

Linux CI (pytorch-linux-xenial-py3.6-gcc5.4) / test (1/1)

🚧 2 fixed upstream failures:

BowenBao commented May 19, 2021 •

edited

Loading

facebook-github-bot commented May 19, 2021 •

edited

Loading