Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Update special post process for SequenceInsert after SequenceEmpty (#56965) #58578

Closed
wants to merge 1 commit into from

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented May 19, 2021

Stack from ghstack:

ONNX::SequenceEmpty requires dtype to be provided, and is default to float. We updates previous dtype of created ONNX::SequenceEmpty node when dtype is later discovered to be other than float, through downstream ONNX::SequenceInsert node. This PR improves the algorithm to cover nested loop case.

Co-authored-by: BowenBao bowbao@microsoft.com

…mpty (#56965)

`ONNX::SequenceEmpty` requires dtype to be provided, and is default to float. We updates previous dtype of created `ONNX::SequenceEmpty` node when dtype is later discovered to be other than float, through downstream `ONNX::SequenceInsert` node. This PR improves the algorithm to cover nested loop case.

Co-authored-by: BowenBao <bowbao@microsoft.com>

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue cla signed labels May 19, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 19, 2021

💊 CI failures summary and remediations

As of commit ab07251 (more details on the Dr. CI page):


  • 1/2 failures introduced in this PR
  • 1/2 broken upstream at merge base 7040e55 on May 19 from 8:24am to 2:23pm

1 failure not recognized by patterns:

Job Step Action
CircleCI pytorch_linux_bionic_cuda10_2_cudnn7_py3_9_gcc7_test1 Run tests 🔁 rerun

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #58578 (ab07251) into gh/BowenBao/67/base (7040e55) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@                   Coverage Diff                   @@
##           gh/BowenBao/67/base   #58578      +/-   ##
=======================================================
- Coverage                76.69%   76.69%   -0.01%     
=======================================================
  Files                     1997     1997              
  Lines                   200833   200864      +31     
=======================================================
+ Hits                    154038   154043       +5     
- Misses                   46795    46821      +26     

@BowenBao BowenBao closed this May 20, 2021
@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/67/head branch June 20, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed oncall: jit Add this issue/PR to JIT oncall triage queue open source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants