-
Notifications
You must be signed in to change notification settings - Fork 23.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE][pytree][Easy] change imports torch.utils._pytree
-> torch.utils.pytree.python
#144405
Open
XuehaiPan
wants to merge
7
commits into
gh/XuehaiPan/219/base
Choose a base branch
from
gh/XuehaiPan/219/head
base: gh/XuehaiPan/219/base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+378
−366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuehaiPan
requested review from
avikchaudhuri,
tugsbayasgalan,
zhxchen17,
ydwu4,
angelayi,
kulinseth,
malfet,
bdhirsh,
zou3519,
mruberry,
titaiwangms,
shubhambhokare1,
justinchuby,
wschin and
jerryzh168
as code owners
January 8, 2025 16:33
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144405
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 1a7e6b1 with merge base 08be9ec (): UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
ciflow/mps
Run MPS tests (subset of trunk)
module: distributed_checkpoint
labels
Jan 8, 2025
pytorch-bot
bot
added
module: dynamo
module: inductor
oncall: distributed
Add this issue/PR to distributed oncall triage queue
release notes: quantization
release notes category
release notes: distributed (fsdp)
release notes category
labels
Jan 8, 2025
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jan 8, 2025
…e.python` ghstack-source-id: b21f6819858ef16a58f3c95ab4a231fe4dffaf52 Pull Request resolved: pytorch#144405
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jan 8, 2025
…e.python` ghstack-source-id: b21f6819858ef16a58f3c95ab4a231fe4dffaf52 Pull Request resolved: pytorch#144405
XuehaiPan
requested review from
eqy,
syed-ahmed,
ezyang,
Chillee,
kshitij12345,
a team,
albanD,
jbschlosser and
mikaylagawarecki
as code owners
January 8, 2025 17:53
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jan 8, 2025
…e.python` ghstack-source-id: 62ebe94e9672ec36bec5701a8394d50cc9ed5498 Pull Request resolved: pytorch#144405
XuehaiPan
added
the
suppress-bc-linter
Suppresses the failures of API backward-compatibility linter (Lint/bc_linter)
label
Jan 8, 2025
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jan 9, 2025
…ls.pytree.python` ghstack-source-id: a1ee79ed5f81bec480a70b053a5f0887f10530fe Pull Request resolved: pytorch#144405
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jan 9, 2025
…ls.pytree.python` ghstack-source-id: f2f54a5f9da2190416d4e617974c010631a9648a Pull Request resolved: pytorch#144405
XuehaiPan
changed the title
[BE][Easy] change imports
[BE][pytree][Easy] change imports Jan 9, 2025
torch.utils._pytree
-> torch.utils.pytree.python
torch.utils._pytree
-> torch.utils.pytree.python
XuehaiPan
added
module: pytree
and removed
suppress-bc-linter
Suppresses the failures of API backward-compatibility linter (Lint/bc_linter)
labels
Jan 9, 2025
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jan 9, 2025
…ls.pytree.python` ghstack-source-id: f2f54a5f9da2190416d4e617974c010631a9648a Pull Request resolved: pytorch#144405
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jan 9, 2025
…ls.pytree.python` ghstack-source-id: 5fbaee12c5f6fe2edfb7581aafa86aec343c7d39 Pull Request resolved: pytorch#144405
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jan 10, 2025
…ls.pytree.python` ghstack-source-id: 5fbaee12c5f6fe2edfb7581aafa86aec343c7d39 Pull Request resolved: pytorch#144405
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jan 10, 2025
…ls.pytree.python` ghstack-source-id: 189970aee5199c37626db72954491318dbfbc47e Pull Request resolved: pytorch#144405
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jan 10, 2025
…ls.pytree.python` ghstack-source-id: 13730be0401e349873f138eba626a5168ad5c06e Pull Request resolved: pytorch#144405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/inductor
ciflow/mps
Run MPS tests (subset of trunk)
fx
module: distributed_checkpoint
module: dynamo
module: inductor
module: pytree
oncall: distributed
Add this issue/PR to distributed oncall triage queue
open source
release notes: distributed (fsdp)
release notes category
release notes: quantization
release notes category
topic: not user facing
topic category
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
torch.utils.pytree
by default #138056torch.distributed
#144332torch.func
#137884torch.utils._pytree
->torch.utils.pytree.python
#144405torch.utils.pytree
as public API #137400dict
keys in insertion order in CXX pytree #130140cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @zou3519 @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov @LucasLLC @MeetVadakkanchery @mhorowitz @pradeepfn @ekr0