Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip AOTI UTs on Windows. #138173

Closed
wants to merge 2 commits into from
Closed

skip AOTI UTs on Windows. #138173

wants to merge 2 commits into from

Conversation

xuhancn
Copy link
Collaborator

@xuhancn xuhancn commented Oct 17, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 17, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138173

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 64b1fa7 with merge base 38d9924 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@xuhancn xuhancn added module: windows Windows support for PyTorch ciflow/trunk Trigger trunk jobs on your pull request intel This tag is for PR from Intel labels Oct 17, 2024
@xuhancn xuhancn mentioned this pull request Oct 17, 2024
Open
@xuhancn xuhancn requested a review from jansel October 17, 2024 05:45
@xuhancn xuhancn requested review from jgong5 and desertfire October 17, 2024 05:46
@xuhancn
Copy link
Collaborator Author

xuhancn commented Oct 17, 2024

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased xu_windows_skip_aoti_UTs onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout xu_windows_skip_aoti_UTs && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the xu_windows_skip_aoti_UTs branch from aecb9dd to 3724940 Compare October 17, 2024 06:37
@xuhancn xuhancn force-pushed the xu_windows_skip_aoti_UTs branch from 3724940 to 64b1fa7 Compare October 17, 2024 06:45
@xuhancn xuhancn requested a review from ezyang October 17, 2024 08:36
desertfire
desertfire reviewed Oct 17, 2024
View reviewed changes
test/inductor/test_torchinductor.py
@@ -1680,6 +1680,7 @@ def flip(x):
actual = _run_and_assert_no_indirect_indexing(self, flip_opt, x)
self.assertEqual(expect, actual)

@skipIfWindows(msg="AOTI not support Windows: aoti_torch_check failed.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the error msg? aoti_torch_check is just a utility function which cuts the dependency on libtorch. This test ifself is not an AOTI test. It should work for Windows.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytorch/torch/csrc/inductor/aoti_torch/c/shim.h

Line 47 in 20af56d

// #define AOTI_TORCH_EXPORT __declspec(dllexport)
@desertfire it is comment the export declare as not support aoti. So it reporting link issue.
Or we enable the export declare on Windows?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the remaining gaps if we export it for Windows now?

@drisspg drisspg added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 18, 2024
@xuhancn
Copy link
Collaborator Author

xuhancn commented Nov 22, 2024

Close by new PR: #140030 CC: @desertfire, @jgong5

@xuhancn xuhancn closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertfire desertfire desertfire left review comments

@jansel jansel jansel approved these changes

@jgong5 jgong5 Awaiting requested review from jgong5

@ezyang ezyang Awaiting requested review from ezyang

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request intel This tag is for PR from Intel module: inductor module: windows Windows support for PyTorch open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@xuhancn @pytorchmergebot @jansel @desertfire @jgong5 @pytorchbot @drisspg