Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add None return type to init -- tests rest #132376

Closed
wants to merge 2 commits into from

Conversation

Copy link

pytorch-bot bot commented Aug 1, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132376

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a2d8cfa with merge base 043e41f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

oulgen added a commit that referenced this pull request Aug 1, 2024
ghstack-source-id: 077d5db5871d4157d8d590a85bd521da1d48393c
Pull Request resolved: #132376
@oulgen oulgen requested review from albanD and aorenste August 1, 2024 03:35
@oulgen oulgen added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 1, 2024
cc XilunWu H-Huang awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang LucasLLC MeetVadakkanchery mhorowitz

[ghstack-poisoned]
oulgen added a commit that referenced this pull request Aug 1, 2024
ghstack-source-id: f3e45fa0022cf26e83e3067e2a27e7b8278c68cf
Pull Request resolved: #132376
@albanD albanD removed their request for review August 1, 2024 14:26
@oulgen
Copy link
Contributor Author

oulgen commented Aug 1, 2024

@pytorchbot merge -f "ignore sanity checks LOC limit"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/oulgen/112/head branch September 1, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: distributed_checkpoint module: dynamo module: inductor oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants