Arm backend: Move batchnorm decomposition to pass #8050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8050
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 6c70e74 with merge base 9d4e1ee ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
|
Please rebase now that 5f849ca is merged. |
The decomposition logic of batchnorm is better suited for a pass than a node visitor. Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> Change-Id: I859912dc6ed437aa96a3bcdd819531dc8e02230e
oscarandersson8218
force-pushed
the
batchnorm_decomp
branch
from
2da80c8 to
6c70e74
Compare
zingo
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The decomposition logic of batchnorm is better suited for a pass than a node visitor.
Change-Id: I859912dc6ed437aa96a3bcdd819531dc8e02230e
cc @digantdesai @freddan80 @per @zingo