Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semver: fix PEP 440 compatible release parsing #55

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

abn
Copy link
Member

@abn abn commented Jul 28, 2020

@abn abn requested a review from a team July 28, 2020 10:41
@sdispater
Copy link
Member

It should fix python-poetry/poetry#2737 as well.

Copy link

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes the root cause, but not the fact that it failed silently.

@abn
Copy link
Member Author

abn commented Jul 28, 2020

It fixes the root cause, but not the fact that it failed silently.

@ewjoachim yes that is correct. Unfortunately, we need a better way to handle those logs. The issue is that the failure was handled as expected in the sense that current logic explicitly handles the issue by skipping the dependency. Not ideal. Either we need to raise an error gracefully, or simply propagate the relevant log correctly.

@abn abn merged commit 63b04d4 into python-poetry:master Jul 28, 2020
@abn abn deleted the pep440-compatible-release branch July 28, 2020 11:32
@PetterS
Copy link

PetterS commented Jul 31, 2020

It fixes the root cause, but not the fact that it failed silently.

Completely agree that we need to aim for much more robustness.

@ewjoachim
Copy link

ewjoachim commented Jul 31, 2020

@PetterS the "failing silently" part was addressed in python-poetry/poetry#2738 & python-poetry/poetry#2739 by @abn and @sdispater ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing asgiref dependency for django
4 participants