Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subdirectory option for url dependencies #7840

Open
2 tasks done
mateo-roldan-sg opened this issue Apr 26, 2023 · 4 comments
Open
2 tasks done

Support subdirectory option for url dependencies #7840

mateo-roldan-sg opened this issue Apr 26, 2023 · 4 comments
Labels
kind/feature Feature requests/implementations status/triage This issue needs to be triaged

Comments

@mateo-roldan-sg
Copy link

mateo-roldan-sg commented Apr 26, 2023

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the FAQ and general documentation and believe that my question is not already covered.

Feature Request

As with the subdirectory option on git dependencies, it would be nice to be able to install from urls pointing to archive files where the target project is not at the root level. This is convenient for example when installing from the archives GitHub automatically creates for tags, like https://github.com/{owner}/{repo}/archive/refs/tags/{tag}.tar.gz.

It's worth noting that pip does support it, e.g.:

myproject @ https://github.com/{owner}/{repo}/archive/refs/tags/{tag}.tar.gz#subdirectory={myproject_dir}

Although it doesn't seem to be explicitly documented.

As a side note, I guess that support for the subdirectory option could be added for local archive files too, that is when providing a path dependency. But that implies also supporting it when the path is just a directory, which seems quite pointless.

@mateo-roldan-sg mateo-roldan-sg added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Apr 26, 2023
@dimbleby
Copy link
Contributor

duplicate #5811 please close

@radoering
Copy link
Member

Technically, #5811 is a (probably stale) PR. If there is not an issue yet (I haven't searched for one), I think we can keep this one open.

As for local path dependencies, python-poetry/poetry-core#467 is a prerequisite.

@mateo-roldan-sg
Copy link
Author

Thanks! I think I didn't find it because only searched for issues, not PRs.

@mateo-roldan-sg
Copy link
Author

Is there anything I can do to help this move forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Feature requests/implementations status/triage This issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

3 participants