Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flake8 with pylint #280

Closed
wants to merge 4 commits into from
Closed

Replace flake8 with pylint #280

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7c7c26
Add pylint config
nir0s Jul 1, 2021
85c52b8
Fix linting issues
nir0s Jul 1, 2021
d241fa2
Make CI config correspond with pylint addition
nir0s Jul 1, 2021
b64e5b3
Don't lint on Python 2.7
nir0s Jul 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Don't lint on Python 2.7
  • Loading branch information
@nir0s
nir0s committed Jul 1, 2021
commit b64e5b3ac325d2c4825dcd736ba8e175e62a3b8f
2 changes: 0 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ jobs:
strategy:
matrix:
include:
- python: 2.7
toxenv: pylint27
- python: 3.8
toxenv: pylint38

Expand Down
6 changes: 1 addition & 5 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

[tox]
minversion = 1.7.2
envlist = pylint27, pylint38, py27, py3{4,5,6,7,8}, pypy{2,3}
envlist = pylint38, py27, py3{4,5,6,7,8}, pypy{2,3}
skip_missing_interpreters = true

[testenv]
Expand All @@ -31,10 +31,6 @@ commands= pytest --cov-report term-missing --cov distro tests -v
basepython = {env:PYTHON:}\python.exe
passenv= ProgramFiles LOGNAME USER LNAME USERNAME HOME USERPROFILE

[testenv:pylint27]
basepython = python2.7
commands = pylint distro.py

[testenv:pylint38]
basepython = python3.8
commands = pylint distro.py