Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace flake8 with pylint #280

Closed
wants to merge 4 commits into from
Closed

Replace flake8 with pylint #280

wants to merge 4 commits into from

Conversation

nir0s
Copy link
Collaborator

@nir0s nir0s commented Jul 1, 2021

  • Add .pylintrc
  • Add pylint config to CI workflow and tox.
  • Fix linting issues. For more info, see the commit message for 85c52b8
  • Remove py27 linting. It's EOL. Not sure if that makes sense right now, given that we test on 27. However, I'm not sure we should lint for it. Thoughts?

nir0s added 4 commits July 1, 2021 15:42
@nir0s
Add pylint config
a7c7c26
@nir0s
Fix linting issues
85c52b8 
Some errored are currently disabled, just to get things going.

We can then start removing those disabled errors by explicitly deciding
on how to handle them.
@nir0s
Make CI config correspond with pylint addition
d241fa2
@nir0s
Don't lint on Python 2.7
b64e5b3
@jdufresne
Copy link
Member

Remove py27 linting. It's EOL. Not sure if that makes sense right now, given that we test on 27. However, I'm not sure we should lint for it. Thoughts?

I think we should remove EOL Pythons. I've done so in PR #281.

@sethmlarson
Copy link
Contributor

Isn't flake8 more complete than pylint? I've not seen projects moving from flake8 -> pylint, usually the other way.

@jdufresne
Copy link
Member

FWIW, most projects I have worked on choose flake8 over pylint. So it is my personal choice as well. (But only that, personal)

@hartwork
Copy link
Contributor

hartwork commented Jul 1, 2021

@nir0s what is the motivation behind choosing pylint over flake8?

@nir0s
Copy link
Collaborator Author

nir0s commented Jul 1, 2021

Yeah, I was making assumptions here. I personally moved away from flake8 in different projects because I felt like it has better reporting.

However, I'm not strongly opinionated about this.

@nir0s
Copy link
Collaborator Author

nir0s commented Jul 1, 2021

I'm gonna close it. It's not worth a discussion AFAIC.

@nir0s nir0s closed this Jul 1, 2021
@nir0s nir0s deleted the replace-flake8-with-pylint branch September 26, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nir0s @jdufresne @sethmlarson @hartwork