chore: update dependencies, fixing tests #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
==========================================
- Coverage 98.66% 98.40% -0.27%
==========================================
Files 11 11
Lines 1052 1063 +11
Branches 199 200 +1
==========================================
+ Hits 1038 1046 +8
- Misses 6 8 +2
- Partials 8 9 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This was referenced Dec 17, 2022
JonasKs
commented
Apr 4, 2023
| @@ -60,7 +60,7 @@ async def watch_reload(path: str, worker_settings: 'WorkerSettingsType') -> None | |||
| except ImportError as e: # pragma: no cover | |||
| raise ImportError('watchfiles not installed, use `pip install watchfiles`') from e | |||
|
|
|||
| loop = asyncio.get_event_loop() | |||
| loop = asyncio.get_running_loop() | |||
There was a problem hiding this comment.
Pipelines fixed themselves, so I don't think we need to merge this PR.
This is somewhat still relevant, but also not really needed. Feel free to close.
Another potential good thing to do is to use get_running_loop() over get_event_loop(), as per documentation.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT April 4th: Seems like this PR is no longer needed, as pipelines have fixed themselves.
As mentioned in #377 (comment):
I also added
But I can remove this if you'd like.
I can rebase the other PRs I have open if this gets merged to make pipelines pass. 😊