Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing background infrastructure for recursive types: Part 1 #7330

Merged
merged 19 commits into from
Aug 16, 2019
Merged

Implementing background infrastructure for recursive types: Part 1 #7330

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
18395a4
Start working on the boring part
ilevkivskyi Aug 10, 2019
a100d9e
Clean types
ilevkivskyi Aug 11, 2019
cd69959
Clean types
ilevkivskyi Aug 11, 2019
50ddf45
Clean core typeops
ilevkivskyi Aug 11, 2019
5f1d095
More cleanups
ilevkivskyi Aug 11, 2019
80f33f0
Cleanup plugins
ilevkivskyi Aug 11, 2019
326df40
Cleanup daemon
ilevkivskyi Aug 11, 2019
fc25baa
Even more clean-ups
ilevkivskyi Aug 11, 2019
f2f89f2
Cleanup semanal helpers
ilevkivskyi Aug 11, 2019
1081bcc
Remove unused ignores
ilevkivskyi Aug 11, 2019
d407437
Fix lint
ilevkivskyi Aug 11, 2019
0e79cc2
Add some docs and infrastructure
Aug 13, 2019
b72b0f0
Some more updates
Aug 13, 2019
9a2ed70
Bake out visitor stubs
Aug 13, 2019
1a9131d
More comments and formatting
Aug 13, 2019
312b057
Try fixing 3.5.1
Aug 13, 2019
c6e0bf8
Fix flake8 broken by conditionally defining overload
Aug 13, 2019
ebb5348
Address some comments
Aug 15, 2019
de97e18
Add one more comment
Aug 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More comments and formatting
  • Loading branch information
Ivan Levkivskyi committed Aug 13, 2019
commit 1a9131d30d4a381c5202b8b5939fccf9e74315d8
12 changes: 12 additions & 0 deletions misc/proper_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,17 @@


class ProperTypePlugin(Plugin):
"""
A plugin to ensure that every type is expanded before doing any special-casing.

This solves the problem that we have hundreds of call sites like:

if isinstance(typ, UnionType):
... # special-case union

But after introducing a new type TypeAliasType (and removing immediate expansion)
all these became dangerous because typ may be e.g. an alias to union.
"""
def get_function_hook(self, fullname: str
) -> Optional[Callable[[FunctionContext], Type]]:
if fullname == 'builtins.isinstance':
Expand Down Expand Up @@ -45,6 +56,7 @@ def isinstance_proper_hook(ctx: FunctionContext) -> Type:


def is_improper_type(typ: Type) -> bool:
"""Is this a type that is not a subtype of ProperType?"""
typ = get_proper_type(typ)
if isinstance(typ, Instance):
info = typ.type
Expand Down
2 changes: 1 addition & 1 deletion mypy/server/astdiff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class level -- these are handled at attribute level (say, 'mod.Cls.method'
from mypy.types import (
Type, TypeVisitor, UnboundType, AnyType, NoneType, UninhabitedType,
ErasedType, DeletedType, Instance, TypeVarType, CallableType, TupleType, TypedDictType,
UnionType, Overloaded, PartialType, TypeType, LiteralType
UnionType, Overloaded, PartialType, TypeType, LiteralType,
)
from mypy.util import get_prefix

Expand Down
2 changes: 1 addition & 1 deletion mypy/server/astmerge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
Type, SyntheticTypeVisitor, Instance, AnyType, NoneType, CallableType, DeletedType,
TupleType, TypeType, TypeVarType, TypedDictType, UnboundType, UninhabitedType, UnionType,
Overloaded, TypeVarDef, TypeList, CallableArgument, EllipsisType, StarType, LiteralType,
RawExpressionType, PartialType
RawExpressionType, PartialType,
)
from mypy.util import get_prefix, replace_object_state
from mypy.typestate import TypeState
Expand Down