gh-123828: fix data raceing for _waiting_release method in _interpchannelsmodule.c #124107
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erpchannelsmodule.c Signed-off-by: Manjusaka <me@manjusaka.me>
Zheaoli
force-pushed
the
manjusaka/fix-123828
branch
from
d8a89c1 to
ffee4ed
Compare
Zheaoli
changed the title
picnixz
reviewed
Sep 15, 2024
|
@picnixz out of the scope of this PR, but would it be feasible to migrate things using |
|
Maybe. Haven't had the time to think about it and I don't know if it's possible for every case. Could you open another issue for that? also how would performances / maintenance cost be impacted? |
It's probably worth discussing on discourse before opening an issue. AFAIK, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #123828