-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bolt instrumentation missing -update-debug-sections
#128437
Comments
This was referenced Jan 3, 2025
corona10
pushed a commit
that referenced
this issue
Jan 5, 2025
…128455) Add `BOLT_COMMON_FLAGS` with `-update-debug-sections` Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jan 5, 2025
pythongh-128455) Add `BOLT_COMMON_FLAGS` with `-update-debug-sections` (cherry picked from commit b60044b) Co-authored-by: Zanie Blue <contact@zanie.dev> Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jan 5, 2025
pythongh-128455) Add `BOLT_COMMON_FLAGS` with `-update-debug-sections` (cherry picked from commit b60044b) Co-authored-by: Zanie Blue <contact@zanie.dev> Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
Bug description:
The following warning is displayed during BOLT instrumentation
The flag is provided during "apply"
cpython/configure.ac
Line 2184 in 81376fe
but not during "instrumentation"
cpython/configure.ac
Line 2170 in 81376fe
Reproduced with
Additional logs
This was patched downstream in
python-build-standalone
astral-sh/python-build-standalone#463 — I'm interesting in upstreaming that patch.A simple patch like
is sufficient — but downstream a
BOLT_COMMON_FLAGS
variable was added which was useful for subsequent fixes.CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Linked PRs
BOLT_COMMON_FLAGS
with-update-debug-sections
#128455BOLT_COMMON_FLAGS
with-update-debug-sections
(gh-128455) #128512BOLT_COMMON_FLAGS
with-update-debug-sections
(gh-128455) #128513The text was updated successfully, but these errors were encountered: