Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search test by name #47

Open
RibeiroAna opened this issue May 25, 2016 · 4 comments
Open

Search test by name #47

RibeiroAna opened this issue May 25, 2016 · 4 comments
Labels
enhancement This issue/PR relates to a feature request. help wanted

Comments

@RibeiroAna
Copy link
Member

It would be nice if there was a search box where the user could search by the test tittle

@davidedelvento
Copy link

How would that differ from CTRL-F in the browser?

@davehunt
Copy link
Collaborator

davehunt commented Jun 3, 2016

How would that differ from CTRL-F in the browser?

I believe this would filter the results, rather than jump to the next/previous occurrence. It could be useful for showing tests within a certain class, etc.

@davehunt davehunt added enhancement This issue/PR relates to a feature request. help wanted labels Jul 20, 2016
@kiran-vemuri
Copy link

Since you're already using a table to display results, you could use datatables api to achieve sorting and searching with minimal code https://datatables.net/examples/api/regex.html

@denisra
Copy link
Contributor

denisra commented Nov 23, 2016

I spent some time looking into this and using datatables might not be as simple as it sounds in this case. The problem is that we use multiple tags and datatables doesn't know how to handle them. I can think of 2 potential solutions to this problem:

1 - Restructure the table so it will have a single tag and everything else will be . We can still collapse/hide these rows fairly easy, since they already have a different class.

2 - Keep everything as it is and use a different solution to do the search. It'll probably need to be written from scratch.

I'm leaning towards #1 as it will give us a better structured html and we can benefit from all the other features provided by datatables (sorting, styling, row grouping, etc), but I'm open to suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue/PR relates to a feature request. help wanted
Projects
None yet
Development

No branches or pull requests

5 participants