Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pytest-html screen real-estate usage #212

Open
ssbarnea opened this issue Jun 24, 2019 · 3 comments
Open

Improve pytest-html screen real-estate usage #212

ssbarnea opened this issue Jun 24, 2019 · 3 comments
Labels
enhancement This issue/PR relates to a feature request. proposal This issue/PR is meant to gather feedback on an idea/change

Comments

@ssbarnea
Copy link
Member

Currently pytest-html report is wasting a huge amount of valuable screen space with boilerplace stuff, which most of the time are of no use to the user. In 99% of the cases the user that opens a report is doing it because a test failed, so he should not have to scroll down in order to find out which test failed.

I proposed few changes in the annotated screenshot I made in order to get some feedback from project maintainers regarding if they want these feature or not. Once I get the feedback I can work on making a PR to improve the output.
pytest-html-report-improve

@BeyondEvil
Copy link
Contributor

@ssbarnea Really good ideas! I don't have any objections. We should however be careful to not introduce any breaking changes. Specifically regarding the hooks. (Not that I think that any of the proposed changes would cause that.)

@fenchu
Copy link

fenchu commented Aug 29, 2019

I also like to be able to put screenshots vertically and not just horizontally, if you have many screenshots in one test they take from the screen capture output.

The environment stuff is also a big security issue. We use gitlab ci to deploy containers and pytest-html pics up all the CI_* and GITLAB_* environment variables, they are useless for the the test but holds the project token and password in public

@BeyondEvil
Copy link
Contributor

BeyondEvil commented Aug 29, 2019

@fenchu

I also like to be able to put screenshots vertically and not just horizontally, if you have many screenshots in one test they take from the screen capture output.

We have a solution in #112 and I'm happy to have someone take over that from me!

The environment stuff is also a big security issue. We use gitlab ci to deploy containers and pytest-html pics up all the CI_* and GITLAB_* environment variables, they are useless for the the test but holds the project token and password in public

You can remove useless/sensitive metadata per the instructions here.

@gnikonorov gnikonorov added enhancement This issue/PR relates to a feature request. proposal This issue/PR is meant to gather feedback on an idea/change labels Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue/PR relates to a feature request. proposal This issue/PR is meant to gather feedback on an idea/change
Projects
None yet
Development

No branches or pull requests

4 participants