Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import: New lexers for PostScript and Abc #8

Closed
wants to merge 7 commits into from
Closed

Import: New lexers for PostScript and Abc #8

wants to merge 7 commits into from

Conversation

pyrmont
Copy link
Owner

@pyrmont pyrmont commented May 11, 2019

This imports jneen#1092.

@pyrmont
Copy link
Owner Author

pyrmont commented May 11, 2019

@taasan I can't speak for the maintainers of the official Rouge project but I think it would be better to avoid the class instance variables that you're using in the Abc lexer, if for no other reason that it's not consistent with the way the other code is written.

@pyrmont
Copy link
Owner Author

pyrmont commented May 11, 2019

@taasan You've also got a large number of errors.

From a quick look, the errors are generally occurring because of the source input test. The text you're using could be used in many different languages and the ambiguity of that is causing the failure. You may just want to remove these tests. If you have a look at the spec for the lexers in the main repo, you'll see that a lot of them do not include this test.

@pyrmont pyrmont changed the title Import: Taasan lexers #1092 Import: New lexers for PostScript and Abc May 11, 2019
@pyrmont
Copy link
Owner Author

pyrmont commented Jun 13, 2019

This is being discussed in rouge-ruby#1092.

@pyrmont pyrmont closed this Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants