Skip to content

Commit

Permalink
Fix shebang regex in Python lexer
Browse files Browse the repository at this point in the history
The Python lexer only supported minor version numbers for shebangs
involving `python2`. Minor versions of Python 3 should also be included.
This commit corrects that problem and supports minor version numbers
higher than 9. This fixes rouge-ruby#945.
  • Loading branch information
pyrmont committed Jun 12, 2019
1 parent 2151912 commit 87f302b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/rouge/lexers/python.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class Python < RegexLexer
mimetypes 'text/x-python', 'application/x-python'

def self.detect?(text)
return true if text.shebang?(/pythonw?(3|2(\.\d)?)?/)
return true if text.shebang?(/pythonw?(?:[23](?:\.\d+)?)?$/)
end

def self.keywords
Expand Down
4 changes: 3 additions & 1 deletion spec/lexers/python_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,11 @@

it 'guesses by source' do
assert_guess :source => '#!/usr/bin/env python'
assert_guess :source => '#!/usr/local/bin/python3'
assert_guess :source => '#!/usr/bin/python2'
assert_guess :source => '#!/usr/bin/python2.7'
assert_guess :source => '#!/usr/local/bin/python3'
assert_guess :source => '#!/usr/local/bin/python3.5'
assert_guess :source => '#!/usr/local/bin/python3.14'
deny_guess :source => '#!/usr/bin/env python4'
end
end
Expand Down

0 comments on commit 87f302b

Please sign in to comment.