-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Make install editable option an option #2299
Conversation
ref #2279 |
Something’s wrong :/ |
Thanks for the PR! the I wish it were this simple, but unfortunately its' not, if you want to iterate on this I'm happy to point you in the right direction |
@techalchemy @uranusjr yep, I found that it is handled in multiple places in the code... I'll dig it out and iterate this PR. |
No worries and no rush, this one is gonna be a pain :p |
does this belong in a subcommand with the |
Yes, |
(you shoudl probably link to version 6) |
OK, I'll add the multiple and the test |
…tall-editable-option
…penv into make-install-editable-option
…tall-editable-option
i don't think this is neccessary, but thank you. |
@kennethreitz, I believe it is normal to expect that Currently, the |
-e is not an argument to install, it's an argument to pip. |
everything after 'install' is passed to pip. it's a pip feature, not a pipenv feature. |
Oh, that's interesting! I didn't know that |
I don't think the logic that is supposed to pass command line options to Pip really works as intended. Here I tried to use
|
that's not exactly how it works |
let the -e option show in
pipenv install -h
and to be an option.