Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for MutableMapping methods on object_maps and fix bug #3297

Merged
merged 13 commits into from
Nov 30, 2022
Merged

Add test for MutableMapping methods on object_maps and fix bug #3297

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7085b5e
Add test for MutableMapping methods on object_maps and fix bug
hoodmane Nov 28, 2022
1290606
Assert that another object is a JsMap
hoodmane Nov 28, 2022
c95af1a
Update changelog
hoodmane Nov 28, 2022
892e87c
as_object_map returns a map
hoodmane Nov 28, 2022
3239163
Update subclass check, split Map into MutableMap and Map, add docstrings
hoodmane Nov 29, 2022
66b8f78
Merge branch 'main' into as-obj-map-mapping-methods
hoodmane Nov 29, 2022
5e50004
Merge branch 'main' into as-obj-map-mapping-methods
hoodmane Nov 29, 2022
e0a3ff5
Fix
hoodmane Nov 29, 2022
b019b08
Fix again
hoodmane Nov 29, 2022
9d34121
Fix tests
hoodmane Nov 29, 2022
33e3159
Fix test
hoodmane Nov 29, 2022
a9a9a2a
Fix test
hoodmane Nov 29, 2022
e9c1f64
Move setitem and delitem to JsMutableMap and as_object_map returns a …
hoodmane Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update changelog
  • Loading branch information
@hoodmane
hoodmane committed Nov 28, 2022
commit c95af1a9b8e036d2bdab08dd24e1da758098143d
2 changes: 1 addition & 1 deletion docs/project/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ substitutions:
- {{ Enhancement }} A `JsProxy` now has an `as_object_map` method. This will treat
the object as a mapping over its `ownKeys` so for instance:
`run_js("({a:2, b:3})").as_object_map()["a"]` will return 2.
{pr}`3273`, {pr}`3295`
{pr}`3273`, {pr}`3295`, {pr}`3297`

- {{ Enhancement }} Split up the `JsProxy` documentation class into several
classes, e.g., {any}`JsBuffer`, {any}`JsPromise`, etc. Implemented
Expand Down