Replace Circle-CI CPU_CORES hack with environment variables (now supp…

…orted upstream)
pyodide · Dec 30, 2019 · 6b308e2 · 6b308e2
1 parent f98aaf6
commit 6b308e2
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -4,6 +4,9 @@ defaults: &defaults
   working_directory: ~/repo
   docker:
     - image: iodide/pyodide-env:0.3.1
+  environment:
+    - EMSDK_NUM_CORES: 4
+      EMCC_CORES: 4
 
 jobs:
   build:

diff --git a/Makefile b/Makefile
@@ -14,8 +14,8 @@ PYODIDE_EMCC=$(PYODIDE_ROOT)/ccache/emcc
 PYODIDE_CXX=$(PYODIDE_ROOT)/ccache/em++
 
 SHELL := /bin/bash
-CC=emcc
-CXX=em++
+CC=$(shell which emcc)
+CXX=$(shell which em++)
 OPTFLAGS=-O3
 CFLAGS=$(OPTFLAGS) -g -I$(PYTHONINCLUDE) -Wno-warn-absolute-paths
 CXXFLAGS=$(CFLAGS) -std=c++14

diff --git a/cpython/Makefile b/cpython/Makefile
@@ -30,6 +30,10 @@ BZIP2TARBALL=$(ROOT)/downloads/bzip2-1.0.2.tar.gz
 BZIP2BUILD=$(ROOT)/build/bzip2-1.0.2
 BZIP2URL=ftp://sources.redhat.com/pub/bzip2/v102/bzip2-1.0.2.tar.gz
 
+ifeq ($(shell uname),Darwin)
+	MAC_SDK_PATH := $(shell xcrun --show-sdk-path)
+	MAC_BUILD_VARS := CFLAGS=-I$(MAC_SDK_PATH)/usr/include CXXFLAGS=-I$(MAC_SDK_PATH)/usr/include
+endif
 
 all: $(INSTALL)/lib/$(LIB)
 
@@ -72,13 +76,12 @@ $(BZIP2TARBALL):
 	[ -d $(ROOT)/downloads ] || mkdir $(ROOT)/downloads
 	wget -q -O $@ $(BZIP2URL)
 
-
 $(HOSTPYTHON) $(HOSTPGEN): $(TARBALL)
 	mkdir -p $(HOSTINSTALL)
 	[ -d $(HOSTBUILD) ] || tar -C $(HOSTINSTALL) -xf $(TARBALL)
 	( \
 		cd $(HOSTBUILD); \
-		PKG_CONFIG_PATH="/usr/local/opt/openssl/lib/pkgconfig" ./configure --prefix=$(HOSTINSTALL) || cat config.log && \
+		PKG_CONFIG_PATH="/usr/local/opt/openssl/lib/pkgconfig" ./configure $(MAC_BUILD_VARS) --prefix=$(HOSTINSTALL) || cat config.log && \
 	  make regen-grammar && \
 		make install && \
 		cp Parser/pgen$(EXE) $(HOSTINSTALL)/bin/ && \

diff --git a/emsdk/Makefile b/emsdk/Makefile
@@ -3,13 +3,9 @@ include ../Makefile.envs
 
 all: emsdk/.complete
 
-# We hack the CPU_CORES, because if you use all of the cores on Circle-CI, you
-# run out of memory.
-
 emsdk/.complete:
 	if [ -d emsdk ]; then rm -rf emsdk; fi
 	git clone https://github.com/juj/emsdk.git
-	sed -i -e "s#CPU_CORES = max(multiprocessing.cpu_count()-1, 1)#CPU_CORES = 3#g" emsdk/emsdk
 	( \
 		cd emsdk && \
 		./emsdk install --build=Release sdk-fastcomp-tag-$(EMSCRIPTEN_VERSION)-64bit binaryen-tag-$(EMSCRIPTEN_VERSION)-64bit && \