Phase control in tektronix AFG3152c #1202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added ability to read and update phase , and imported pi from math
corrected docstring typo in phase_deg tektronix afg3152c
flake8
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1202 +/- ##
=======================================
Coverage 59.11% 59.12%
=======================================
Files 273 273
Lines 19001 19004 +3
=======================================
+ Hits 11233 11236 +3
Misses 7768 7768
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -108,6 +112,21 @@ class AFG3152CChannel(Channel): | |||
| values=FREQ_LIMIT, | |||
| ) | |||
|
|
|||
| phase_rad = Instrument.control( | |||
| "phase:adjust?", "phase:adjust %e RAD", | |||
| """Control the phase in radians (float).""", | |||
There was a problem hiding this comment.
Maybe add the limits like "(float strictly between +-pi) "
|
Sorry for the delay. Would you mind adding tests for your new method? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added phase control for a Tektronix arbitrary waveform generator. The get command always returns radians, but the user has the option to set the phase in radians or degrees.