Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing to filepath #4980

Merged
merged 21 commits into from
Sep 16, 2021
Merged

Add typing to filepath #4980

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
dc3696f
Add typing to ``filepath``
DanielNoord Sep 7, 2021
56b1061
Change tests for ``filepath`` changes
DanielNoord Sep 7, 2021
565e245
Code review
DanielNoord Sep 14, 2021
2b46031
Additional code review
DanielNoord Sep 14, 2021
a680a4a
Merge branch 'main' into typing-filepath
DanielNoord Sep 14, 2021
7bd3810
Update pylint/lint/parallel.py
DanielNoord Sep 14, 2021
f4a7045
Add pylint/typing.py and FileItem NamedTuple
DanielNoord Sep 14, 2021
6af1902
Code review
DanielNoord Sep 14, 2021
ccaaa86
Apply suggestions from code review
DanielNoord Sep 15, 2021
4c31342
Use NamedTuple more efficiently
DanielNoord Sep 15, 2021
4859288
Merge branch 'main' of https://github.com/PyCQA/pylint into pyannotat…
DanielNoord Sep 15, 2021
b8ba102
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 15, 2021
096f8a8
Merge branch 'typing-filepath-tests' of https://github.com/DanielNoor…
DanielNoord Sep 15, 2021
0910978
Fix tests and errors
DanielNoord Sep 15, 2021
dd67951
Update pylint/lint/pylinter.py
DanielNoord Sep 16, 2021
32742d2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 16, 2021
cfc01da
Fix errors and tests after adding warning
DanielNoord Sep 16, 2021
21e6f76
Code review
DanielNoord Sep 16, 2021
4df05c5
Fix tests
DanielNoord Sep 16, 2021
58d0e88
Revert docstring change
DanielNoord Sep 16, 2021
0cf4b1f
Apply suggestions from code review
DanielNoord Sep 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
  • Loading branch information
@DanielNoord @cdce8p
DanielNoord and cdce8p authored Sep 15, 2021
commit ccaaa8680eb3481e24753a0c52f8c529c134b570
2 changes: 1 addition & 1 deletion pylint/lint/parallel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def _worker_check_single_file(
return (
id(multiprocessing.current_process()),
_worker_linter.current_name,
file_item[1],
file_item.filepath,
_worker_linter.file_state.base_name,
msgs,
_worker_linter.stats,
Expand Down
2 changes: 1 addition & 1 deletion pylint/lint/pylinter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,7 +940,7 @@ def initialize(self):
def check(self, files_or_modules: Sequence[str]) -> None:
DanielNoord marked this conversation as resolved.
Show resolved Hide resolved
cdce8p marked this conversation as resolved.
Show resolved Hide resolved
"""main checking entry: check a list of files or modules from their name.

files_or_modules is a list of strings presenting modules to check.
files_or_modules is a sequence of strings presenting modules to check.
"""
self.initialize()

DanielNoord marked this conversation as resolved.
Show resolved Hide resolved
Expand Down