Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract username from session #291

Merged
merged 4 commits into from
Jan 6, 2019
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jan 6, 2019

Duplicate of PR #290 to run tests on CI.

@codecov
Copy link

codecov bot commented Jan 6, 2019

Codecov Report

Merging #291 into master will decrease coverage by 0.3%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
- Coverage   95.39%   95.08%   -0.31%     
==========================================
  Files           2        2              
  Lines        1215     1220       +5     
==========================================
+ Hits         1159     1160       +1     
- Misses         56       60       +4
Impacted Files Coverage Δ
pylast/__init__.py 95.07% <37.5%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6134945...fffc647. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 6, 2019

Codecov Report

Merging #291 into master will decrease coverage by 0.3%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
- Coverage   95.39%   95.08%   -0.31%     
==========================================
  Files           2        2              
  Lines        1215     1220       +5     
==========================================
+ Hits         1159     1160       +1     
- Misses         56       60       +4
Impacted Files Coverage Δ
pylast/__init__.py 95.07% <37.5%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6134945...fffc647. Read the comment docs.

@hugovk hugovk merged commit fffc647 into master Jan 6, 2019
@hugovk hugovk deleted the jacebrowning-fix-blank-username branch January 6, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants