-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🗒️❓ Optional evaluation for pipeline #919
base: master
Are you sure you want to change the base?
Conversation
the pipeline has become a proper frankenstein monster at this point |
It might be worth to try to separate the resolution logic from running training / evaluation. |
# Conflicts: # src/pykeen/pipeline/api.py # tests/test_pipeline.py
I am still skeptical of making evaluation optional. I like that the pipeline does exactly one thing, and if you want to roll your own with different functionality, there is a tutorial at https://pykeen.readthedocs.io/en/stable/tutorial/first_steps.html#beyond-the-pipeline that makes it pretty simple It doesn't help that this PR also has big refactoring that isn't obviously relevant to making evaluation optional |
The |
This PR works towards making the evaluation in the
pipeline
function optional.