Allow disabling downloading lib when creating wheel #669
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Korijn
previously approved these changes
Jan 31, 2025
hmaarrfk
reviewed
Jan 31, 2025
|
Testing the patch conda-forge/wgpu-py-feedstock#30 |
|
Would it be possible to also lazyload requests: diff --git a/tools/download_wgpu_native.py b/tools/download_wgpu_native.py
index dfc17c0..6a18acf 100644
--- a/tools/download_wgpu_native.py
+++ b/tools/download_wgpu_native.py
@@ -6,8 +6,6 @@ import tempfile
import platform
from zipfile import ZipFile
-import requests
-
DEFAULT_UPSTREAM = "gfx-rs/wgpu-native"
@@ -49,6 +47,8 @@ def write_current_version(version, commit_sha):
def download_file(url, filename):
+ import requests
+
resp = requests.get(url, stream=True)
with open(filename, mode="wb") as fh:
for chunk in resp.iter_content(chunk_size=1024 * 128):
I'm very weary of having requests as a dependency at build time since many (like this package) will pull in dependencies during the build process. Avoiding the dependency alltogether is an easy smoke test. |
Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
|
can confirm that with the requests patch this works. I mean I don't want to focus our attention on building the best build system. there is always some customization on this front for the build files. Thanks for helping on the maintenance front! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #666
@hmaarrfk Would this simple tweak allow the feedstock to drop another patch?
Not sure if there's an env var that we can check that a conda build is in progress. But in any case I imagine you can set an env var in the recipe.