-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype System class. #81
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
77cd5d4
Prototype System class.
chrisdembia 61cd1a7
WIP: Started tests for System class.
moorepants 29fc9cb
Removing default behaviors from System class.
chrisdembia 418c1fc
Fix bug with mass spring damper kwarg.
chrisdembia 2a5b721
WIP Write most of the System class, with tests.
chrisdembia 3c6344a
Changed the arguments to the generated rhs to support dictionaries.
moorepants bfe2138
Added test for specified dict.
moorepants 9aef7d8
Updated all code to use new dictionary inputs for generate_ode_function.
moorepants 8f30674
About to redo System defaults.
chrisdembia 35cba4d
Replace calls to find_ with custom methods.
chrisdembia d0d945f
Fix some minor typos.
chrisdembia 0ca1d2b
Not making constants, specifieds, and initial conditions properties.
chrisdembia 331aa33
Finish System class, with passing tests.
chrisdembia 826f4d5
Update double_pendulum example to use System.
chrisdembia 964dbe7
Update documentation for System class.
chrisdembia 1778fee
Minor cleanup.
moorepants fd981e7
Restore the fast way of parsing specifieds.
chrisdembia f6c03a3
Edits to the README.
moorepants File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
System class | ||
============ | ||
|
||
.. automodule:: pydy.system | ||
|
||
.. autoclass:: pydy.system.System | ||
:members: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I had been implying for re-integrating Scene visualization stuff.
So that we supply
times
andsys
to the Scene class, and is easier to handle than the existing structure.I am ready to work on integrating this code with
Scene
class(after tomorrow).But also there will be some backwards incompatible changes(in Scene class as well), when this is integrated into Scene.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is why we are creating this, so that you can have something easier to work with in your viz code. It won't be ready tomorrow, but please help contribute to this so we can get it done more quickly.