Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to the camera code. #319

Merged
merged 4 commits into from
Jan 5, 2016
Merged

Improvements to the camera code. #319

merged 4 commits into from
Jan 5, 2016

Conversation

moorepants
Copy link
Member

  • Utilized inheritance from VisualizationFrame.
  • Added more tests.
  • Improved doc strings.
  • Fixed getters/setters.

Review stuff:

  • There are no merge conflicts.
  • If there is a related issue, a reference to that issue is in the
    commit message.
  • Unit tests have been added for the bug. (Please reference the issue #
    in the unit test.)
  • The tests pass both locally (run nosetests) and on Travis CI.
  • The code follows PEP8 guidelines. (use a linter, e.g.
    pylint, to check your code)
  • The bug fix is documented in the Release
    Notes    .
  • The code is backwards compatible. (All public methods/classes must
    follow deprecation cycles.)
  • All reviewer comments have been addressed.

@moorepants
Improvements to the camera code.
e6d7ea6 
- Utilized inheritance from VisualizationFrame.
- Added more tests.
- Improved doc strings.
- Fixed getters/setters.
@moorepants
Made kwargs Python 2 compatible.
8a0f2e9
@moorepants
Copy link
Member Author

@pydy/pydy-developers @yashu-seth This needs a review.

@yashu-seth
Copy link
Contributor

Have the release notes been updated?

@moorepants
Copy link
Member Author

This doesn't change any functionality. It is more or less a bug fix. I'll add a note though.

@moorepants
Copy link
Member Author

Ok, the note has been added.

@moorepants
Copy link
Member Author

@yashu-seth Any more comments here? I'd like to get this merged for the 0.3.1 release.

@yashu-seth
Copy link
Contributor

Everything else seems fine to me.

moorepants added a commit that referenced this pull request Jan 5, 2016
@moorepants
Merge pull request #319 from moorepants/camera-cleanup
d884be2 
Improvements to the camera code.
@moorepants moorepants merged commit d884be2 into pydy:master Jan 5, 2016
@moorepants moorepants deleted the camera-cleanup branch January 6, 2016 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moorepants @yashu-seth