Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos found by codespell #2169

Closed
wants to merge 1 commit into from

Conversation

yarikoptic
Copy link
Contributor

I saw that typos is already used, so thought to not suggest codespell. But it did catch a few more, so proposing but not sure if desired since changes dicts

I saw that typos is already used, so thought to not suggest codespell.
But it did catch a few more, so proposing but not sure if desired since changes
dicts

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git-sedi Minature Miniature; git-sedi Ukranian Ukrainian;",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@yarikoptic yarikoptic changed the title [DATALAD RUNCMD] Fix some typos found by codespell Fix some typos found by codespell Nov 3, 2024
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.39%. Comparing base (abe9a09) to head (eae320b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2169      +/-   ##
==========================================
+ Coverage   98.35%   98.39%   +0.04%     
==========================================
  Files          77       77              
  Lines       13521    13521              
==========================================
+ Hits        13298    13304       +6     
+ Misses        223      217       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all values auto-generated from the respective DICOM dictionaries. Even if these have typos, we can't just change them, as they are defined this way.

@scaramallion
Copy link
Member

scaramallion commented Nov 3, 2024

You can submit a DICOM change proposal instead, see this for an example.

Affected CID is 7480

@yarikoptic
Copy link
Contributor Author

Thank you @mrbean-bremen and @scaramallion , so we should close this then... FTR -- here is update to 2024d

which seems to not carry fixes so indeed might still be "upstream"

@yarikoptic yarikoptic closed this Nov 4, 2024
@scaramallion
Copy link
Member

scaramallion commented Nov 4, 2024

DICOM is using the name that matches the SCT codes, so the problem is with SCT. Both those codes are inactive, though, so they're unlikely to be updated, which in turn means we're probably stuck with the misspelling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants