Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable passing a CFTimedeltaCoder to decode_timedelta #9966

Merged
merged 18 commits into from
Jan 29, 2025
Merged

Enable passing a CFTimedeltaCoder to decode_timedelta #9966

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ff7650f
Allow passing a CFTimedeltaCoder instance to decode_timedelta
spencerkclark Jan 20, 2025
72d1d1c
Updates based on @kmuehlbauer's branch
spencerkclark Jan 20, 2025
714e17d
Increment what's new PR number
spencerkclark Jan 20, 2025
f33ed02
Merge branch 'main' into time_unit-decode_timedelta
kmuehlbauer Jan 22, 2025
9ac19dc
Merge branch 'main' into time_unit-decode_timedelta
dcherian Jan 27, 2025
6d799e7
Merge branch 'main' into time_unit-decode_timedelta
kmuehlbauer Jan 29, 2025
3a96c8a
Add FutureWarning for change in decode_timedelta behavior
spencerkclark Jan 29, 2025
e67f2e4
Include a note about opting out of timedelta decoding
spencerkclark Jan 29, 2025
c5e2234
Merge branch 'time_unit-decode_timedelta' of https://github.com/spenc…
spencerkclark Jan 29, 2025
6ffca3a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 29, 2025
763fde2
Fix typing
spencerkclark Jan 29, 2025
c0f6e8e
Merge branch 'time_unit-decode_timedelta' of https://github.com/spenc…
spencerkclark Jan 29, 2025
5f20901
Fix typo
spencerkclark Jan 29, 2025
cdcc53e
Fix doc build
spencerkclark Jan 29, 2025
921a74f
Fix order of arguments in filterwarnings
spencerkclark Jan 29, 2025
36ab5fd
Switch to :okwarning:
spencerkclark Jan 29, 2025
c01e5d3
Switch to :okwarning:
spencerkclark Jan 29, 2025
3e9f91e
Fix missing :okwarning:
spencerkclark Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions doc/internals/time-coding.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,3 +521,9 @@ into their native on-disk resolution, if possible:

coder = xr.coders.CFDatetimeCoder(time_unit="s")
xr.open_dataset("test-timedeltas2.nc", decode_times=coder)
spencerkclark marked this conversation as resolved.
Show resolved Hide resolved

To opt-out of timedelta decoding (see issue `Undesired decoding to timedelta64 <https://github.com/pydata/xarray/issues/1621>`_) pass ``False`` to ``decode_timedelta``:

.. ipython:: python
xr.open_dataset("test-timedeltas2.nc", decode_times=False)

2 changes: 1 addition & 1 deletion doc/whats-new.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ eventually be deprecated.

New Features
~~~~~~~~~~~~
- Relax nanosecond datetime / timedelta restriction in CF time decoding (:issue:`7493`, :pull:`9618`, :pull:`9966`).
- Relax nanosecond datetime / timedelta restriction in CF time decoding (:issue:`7493`, :pull:`9618`, :pull:`9966`, :pull:`9977`).
By `Kai Mühlbauer <https://github.com/kmuehlbauer>`_ and `Spencer Clark <https://github.com/spencerkclark>`_.
- Enable the ``compute=False`` option in :py:meth:`DataTree.to_zarr`. (:pull:`9958`).
By `Sam Levang <https://github.com/slevang>`_.
Expand Down
Loading