Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dependecy definition of 'packaging' #6207

Merged
merged 12 commits into from
Jan 31, 2022
Merged

Fix missing dependecy definition of 'packaging' #6207

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1e4ae63
🩹 Added packaging to install_requires
s-weigand Jan 29, 2022
1e0901c
Merge branch 'main' into pr/6207
Illviljan Jan 29, 2022
958638a
add packaging dep to ci, install instructions, and whatsnew page
Jan 31, 2022
26421a8
lint
Jan 31, 2022
09c4222
Merge branch 'main' of github.com:pydata/xarray into fix-missing-depe…
Jan 31, 2022
d9e5861
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 31, 2022
ac0cc94
uninstall packaging before installing upstream
Jan 31, 2022
31c4cd5
Merge branch 'fix-missing-dependency' of https://github.com/s-weigand…
Jan 31, 2022
69567a6
Merge branch 'main' of github.com:pydata/xarray into fix-missing-depe…
Jan 31, 2022
abbccb5
update requirements.txt
Jan 31, 2022
4406f36
update whats new and rerun linter
Jan 31, 2022
1c64bd8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .binder/environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ dependencies:
- netcdf4
- numba
- numpy
- packaging
- pandas
- pint
- pip
Expand Down
1 change: 1 addition & 0 deletions ci/install-upstream-wheels.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ python -m pip install \
git+https://github.com/zarr-developers/zarr \
git+https://github.com/Unidata/cftime \
git+https://github.com/mapbox/rasterio \
git+https://github.com/pypa/packaging \
jhamman marked this conversation as resolved.
Show resolved Hide resolved
git+https://github.com/hgrecco/pint \
git+https://github.com/pydata/sparse \
git+https://github.com/intake/filesystem_spec \
Expand Down
1 change: 1 addition & 0 deletions ci/requirements/doc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ dependencies:
- netcdf4>=1.5
- numba
- numpy>=1.17
- packaging>=20.0
- pandas>=1.0
- pooch
- pip
Expand Down
1 change: 1 addition & 0 deletions ci/requirements/environment-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ dependencies:
- netcdf4
- numba
- numpy
- packaging
- pandas
- pint
- pip
Expand Down
1 change: 1 addition & 0 deletions ci/requirements/environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ dependencies:
- numba
- numexpr
- numpy
- packaging
- pandas
- pint
- pip
Expand Down
1 change: 1 addition & 0 deletions ci/requirements/py38-bare-minimum.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@ dependencies:
- pytest-env
- pytest-xdist
- numpy=1.18
- packaging=20.0
- pandas=1.1
1 change: 1 addition & 0 deletions ci/requirements/py38-min-all-deps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ dependencies:
- netcdf4=1.5.3
- numba=0.51
- numpy=1.18
- packaging=20.0
- pandas=1.1
- pint=0.16
- pip
Expand Down
1 change: 1 addition & 0 deletions ci/requirements/py39-all-but-dask.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ dependencies:
- netcdf4
- numba
- numpy
- packaging
- pandas
- pint
- pip
Expand Down
1 change: 1 addition & 0 deletions doc/getting-started-guide/installing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Required dependencies

- Python (3.8 or later)
- `numpy <https://www.numpy.org/>`__ (1.18 or later)
- `packaging <https://packaging.pypa.io/en/latest/#>`__ (20.0 or later)
- `pandas <https://pandas.pydata.org/>`__ (1.1 or later)

.. _optional-dependencies:
Expand Down
3 changes: 2 additions & 1 deletion doc/whats-new.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ Deprecations

Bug fixes
~~~~~~~~~

- Add `packaging` as a dependency to Xarray (:issue:`6216`, :pull:`6207`).
By `Joseph Nowak <https://github.com/josephnowak>`_ and `Joe Hamman <https://github.com/jhamman>`_.
jhamman marked this conversation as resolved.
Show resolved Hide resolved

Documentation
~~~~~~~~~~~~~
Expand Down
1 change: 1 addition & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ python_requires = >=3.8
install_requires =
numpy >= 1.18
pandas >= 1.1
packaging >= 20.0

[options.extras_require]
io =
Expand Down