Address repo-review suggestions

### What is your issue?

Here's the output from the Scientific Python [Repo Review](https://repo-review.readthedocs.io/) tool.

There's an online version [here](https://learn.scientific-python.org/development/guides/repo-review/?repo=pydata%2Fxarray&branch=main).

On mac I run 
```
pipx run 'sp-repo-review[cli]' --format html --show err gh:pydata/xarray@main | pbcopy
```

A lot of these seem fairly easy to fix. I'll note that there's a large number of `mypy` config suggestions.

<h3>General</h3>
<ul>
<li>Detected build backend: <code>setuptools.build_meta</code></li>
<li>Detected license(s): Apache Software License</li>
</ul>
<table>
<tr><th>?</th><th>Name</th><th>Description</th></tr>
<tr style="color: red;">
<td><span role="img" aria-label="Failed">&#10060;</span></td>
<td>PY007</td>
<td>
<a href="https://learn.scientific-python.org/development/guides/tasks#PY007">Supports an easy task runner (nox or tox)</a>
<br/>
<p>Projects must have a <code>noxfile.py</code> or <code>tox.ini</code> to encourage new contributors.</p>

</td>
</tr>
</table>
<h3>PyProject</h3>

See https://github.com/pydata/xarray/issues/8239#issuecomment-1739363809

<table>
<tr><th>?</th><th>Name</th><th>Description</th></tr>
<tr style="color: red;">
<td><span role="img" aria-label="Failed">&#10060;</span></td>
<td>PP305</td>
<td>
<a href="https://learn.scientific-python.org/development/guides/pytest#PP305">Specifies xfail_strict</a>
<br/>
<p><code>xfail_strict</code> should be set. You can manually specify if a check
should be strict when setting each xfail.</p>
<pre><code class="language-toml">[tool.pytest.ini_options]
xfail_strict = true
</code></pre>

</td>
</tr>
<tr style="color: red;">
<td><span role="img" aria-label="Failed">&#10060;</span></td>
<td>PP308</td>
<td>
<a href="https://learn.scientific-python.org/development/guides/pytest#PP308">Specifies useful pytest summary</a>
<br/>
<p><code>-ra</code> should be in <code>addopts = [...]</code> (print summary of all fails/errors).</p>
<pre><code class="language-toml">[tool.pytest.ini_options]
addops = [&quot;-ra&quot;, &quot;--strict-config&quot;, &quot;--strict-markers&quot;]
</code></pre>

</td>
</tr>
</table>
<h3>Pre-commit</h3>
<table>
<tr><th>?</th><th>Name</th><th>Description</th></tr>
<tr style="color: red;">
<td><span role="img" aria-label="Failed">&#10060;</span></td>
<td>PC110</td>
<td>
<a href="https://learn.scientific-python.org/development/guides/style#PC110">Uses black</a>
<br/>
<p>Use <code>https://github.com/psf/black-pre-commit-mirror</code> instead of <code>https://github.com/psf/black</code> in <code>.pre-commit-config.yaml</code></p>

</td>
</tr>
<tr style="color: red;">
<td><span role="img" aria-label="Failed">&#10060;</span></td>
<td>PC160</td>
<td>
<a href="https://learn.scientific-python.org/development/guides/style#PC160">Uses codespell</a>
<br/>
<p>Must have <code>https://github.com/codespell-project/codespell</code> repo in <code>.pre-commit-config.yaml</code></p>

</td>
</tr>
<tr style="color: red;">
<td><span role="img" aria-label="Failed">&#10060;</span></td>
<td>PC170</td>
<td>
<a href="https://learn.scientific-python.org/development/guides/style#PC170">Uses PyGrep hooks (only needed if RST present)</a>
<br/>
<p>Must have <code>https://github.com/pre-commit/pygrep-hooks</code> repo in <code>.pre-commit-config.yaml</code></p>

</td>
</tr>
<tr style="color: red;">
<td><span role="img" aria-label="Failed">&#10060;</span></td>
<td>PC180</td>
<td>
<a href="https://learn.scientific-python.org/development/guides/style#PC180">Uses prettier</a>
<br/>
<p>Must have <code>https://github.com/pre-commit/mirrors-prettier</code> repo in <code>.pre-commit-config.yaml</code></p>

</td>
</tr>
<tr style="color: red;">
<td><span role="img" aria-label="Failed">&#10060;</span></td>
<td>PC191</td>
<td>
<a href="https://learn.scientific-python.org/development/guides/style#PC191">Ruff show fixes if fixes enabled</a>
<br/>
<p>If <code>--fix</code> is present, <code>--show-fixes</code> must be too.</p>

</td>
</tr>
<tr style="color: red;">
<td><span role="img" aria-label="Failed">&#10060;</span></td>
<td>PC901</td>
<td>
<a href="https://learn.scientific-python.org/development/guides/style#PC901">Custom pre-commit CI message</a>
<br/>
<p>Should have something like this in <code>.pre-commit-config.yaml</code>:</p>
<pre><code class="language-yaml">ci:
  autoupdate_commit_msg: 'chore: update pre-commit hooks'
</code></pre>

</td>
</tr>
</table>
<h3>MyPy</h3>
<table>
<tr><th>?</th><th>Name</th><th>Description</th></tr>
<tr style="color: red;">
<td><span role="img" aria-label="Failed">&#10060;</span></td>
<td>MY101</td>
<td>
<a href="https://learn.scientific-python.org/development/guides/style#MY101">MyPy strict mode</a>
<br/>
<p>Must have <code>strict</code> in the mypy config. MyPy is best with strict or
nearly strict configuration. If you are happy with the strictness of
your settings already, ignore this check or set <code>strict = false</code>
explicitly.</p>
<pre><code class="language-toml">[tool.mypy]
strict = true
</code></pre>

</td>
</tr>
<tr style="color: red;">
<td><span role="img" aria-label="Failed">&#10060;</span></td>
<td>MY103</td>
<td>
<a href="https://learn.scientific-python.org/development/guides/style#MY103">MyPy warn unreachable</a>
<br/>
<p>Must have <code>warn_unreachable = true</code> to pass this check. There are
occasionally false positives (often due to platform or Python version
static checks), so it's okay to ignore this check. But try it first - it
can catch real bugs too.</p>
<pre><code class="language-toml">[tool.mypy]
warn_unreachable = true
</code></pre>

</td>
</tr>
<tr style="color: red;">
<td><span role="img" aria-label="Failed">&#10060;</span></td>
<td>MY104</td>
<td>
<a href="https://learn.scientific-python.org/development/guides/style#MY104">MyPy enables ignore-without-code</a>
<br/>
<p>Must have <code>&quot;ignore-without-code&quot;</code> in <code>enable_error_code = [...]</code>. This
will force all skips in your project to include the error code, which
makes them more readable, and avoids skipping something unintended.</p>
<pre><code class="language-toml">[tool.mypy]
enable_error_code = [&quot;ignore-without-code&quot;, &quot;redundant-expr&quot;, &quot;truthy-bool&quot;]
</code></pre>

</td>
</tr>
<tr style="color: red;">
<td><span role="img" aria-label="Failed">&#10060;</span></td>
<td>MY105</td>
<td>
<a href="https://learn.scientific-python.org/development/guides/style#MY105">MyPy enables redundant-expr</a>
<br/>
<p>Must have <code>&quot;redundant-expr&quot;</code> in <code>enable_error_code = [...]</code>. This helps
catch useless lines of code, like checking the same condition twice.</p>
<pre><code class="language-toml">[tool.mypy]
enable_error_code = [&quot;ignore-without-code&quot;, &quot;redundant-expr&quot;, &quot;truthy-bool&quot;]
</code></pre>

</td>
</tr>
<tr style="color: red;">
<td><span role="img" aria-label="Failed">&#10060;</span></td>
<td>MY106</td>
<td>
<a href="https://learn.scientific-python.org/development/guides/style#MY106">MyPy enables truthy-bool</a>
<br/>
<p>Must have <code>&quot;truthy-bool&quot;</code> in <code>enable_error_code = []</code>. This catches
mistakes in using a value as truthy if it cannot be falsey.</p>
<pre><code class="language-toml">[tool.mypy]
enable_error_code = [&quot;ignore-without-code&quot;, &quot;redundant-expr&quot;, &quot;truthy-bool&quot;]
</code></pre>

</td>
</tr>
</table>
<h3>Ruff</h3>
<table>
<tr><th>?</th><th>Name</th><th>Description</th></tr>
<tr style="color: red;">
<td><span role="img" aria-label="Failed">&#10060;</span></td>
<td>RF101</td>
<td>
<a href="https://learn.scientific-python.org/development/guides/style#RF101">Bugbear must be selected</a>
<br/>
<p>Must select the flake8-bugbear <code>B</code> checks. Recommended:</p>
<pre><code class="language-toml">[tool.ruff]
select = [
  &quot;B&quot;,  # flake8-bugbear
]
</code></pre>

</td>
</tr>
</table>





?	Name	Description
❌	PC110	Uses black Use `https://github.com/psf/black-pre-commit-mirror` instead of `https://github.com/psf/black` in `.pre-commit-config.yaml`
❌	PC160	Uses codespell Must have `https://github.com/codespell-project/codespell` repo in `.pre-commit-config.yaml`
❌	PC170	Uses PyGrep hooks (only needed if RST present) Must have `https://github.com/pre-commit/pygrep-hooks` repo in `.pre-commit-config.yaml`
❌	PC180	Uses prettier Must have `https://github.com/pre-commit/mirrors-prettier` repo in `.pre-commit-config.yaml`
❌	PC191	Ruff show fixes if fixes enabled If `--fix` is present, `--show-fixes` must be too.
❌	PC901	Custom pre-commit CI message Should have something like this in `.pre-commit-config.yaml`: `ci: autoupdate_commit_msg: 'chore: update pre-commit hooks'`

?	Name	Description
❌	MY101	MyPy strict mode Must have `strict` in the mypy config. MyPy is best with strict or nearly strict configuration. If you are happy with the strictness of your settings already, ignore this check or set `strict = false` explicitly. `[tool.mypy] strict = true`
❌	MY103	MyPy warn unreachable Must have `warn_unreachable = true` to pass this check. There are occasionally false positives (often due to platform or Python version static checks), so it's okay to ignore this check. But try it first - it can catch real bugs too. `[tool.mypy] warn_unreachable = true`
❌	MY104	MyPy enables ignore-without-code Must have `"ignore-without-code"` in `enable_error_code = [...]`. This will force all skips in your project to include the error code, which makes them more readable, and avoids skipping something unintended. `[tool.mypy] enable_error_code = ["ignore-without-code", "redundant-expr", "truthy-bool"]`
❌	MY105	MyPy enables redundant-expr Must have `"redundant-expr"` in `enable_error_code = [...]`. This helps catch useless lines of code, like checking the same condition twice. `[tool.mypy] enable_error_code = ["ignore-without-code", "redundant-expr", "truthy-bool"]`
❌	MY106	MyPy enables truthy-bool Must have `"truthy-bool"` in `enable_error_code = []`. This catches mistakes in using a value as truthy if it cannot be falsey. `[tool.mypy] enable_error_code = ["ignore-without-code", "redundant-expr", "truthy-bool"]`

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Address repo-review suggestions #8239

What is your issue?

General

PyProject

Pre-commit

MyPy

Ruff

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

?	Name	Description
❌	PP305	Specifies xfail_strict `xfail_strict` should be set. You can manually specify if a check should be strict when setting each xfail. `[tool.pytest.ini_options] xfail_strict = true`
❌	PP308	Specifies useful pytest summary `-ra` should be in `addopts = [...]` (print summary of all fails/errors). `[tool.pytest.ini_options] addops = ["-ra", "--strict-config", "--strict-markers"]`