Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile localized translation when starting development environment #823

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

shunghsiyu
Copy link
Member

Types of changes

Please put an x in the box that applies

  • Bugfix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other: development environment enhancement

Description

Compile localized translation when starting development environment

Steps to Test This Pull Request

Steps to reproduce the behavior:

  1. Start the development environment with the enter_dev_env.sh script
  2. Open localhost:8000/zh-hant/ with web browser

Expected behavior

Content of the webpage is displayed in Traditional Chinese.

Related Issue

See #761 for more context.

@shunghsiyu shunghsiyu requested a review from mattwang44 July 11, 2020 09:42
@codecov-commenter
Copy link

Codecov Report

Merging #823 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #823   +/-   ##
=======================================
  Coverage   76.14%   76.14%           
=======================================
  Files          70       70           
  Lines        2687     2687           
=======================================
  Hits         2046     2046           
  Misses        641      641           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27ecc4b...5381b38. Read the comment docs.

Copy link
Member

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx 💯

@mattwang44 mattwang44 merged commit 32419ee into pycontw:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants