lldb add qemu-user #2628
Merged
lldb add qemu-user #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
patryk4815
commented
Dec 16, 2024
patryk4815
commented
| @@ -1378,7 +1352,7 @@ def handler( | |||
| @override | |||
| def is_linux(self) -> bool: | |||
| # LLDB will at most tell us if this is a SysV ABI process. | |||
| return self.target.GetABIName().startswith("sysv") | |||
| return self.target.GetABIName().lower().startswith("sysv") | |||
There was a problem hiding this comment.
Please add the whole GetABIName() result in a docstring for this function - it will be helpful if this ever changes or if we ever need to add another case for this etc.
Also: do we really have to do .lower()? Do we think the letter sizes may ever be different?
There was a problem hiding this comment.
In [6]: inf.target.GetABIName()
Out[6]: 'SysV-arm64'
In [6]: inf.target.GetABIName()
Out[6]: 'ABIMacOSX_arm64'
pwndbg/dbg/lldb/__init__.py
Outdated
| result, | ||
| False, | ||
| ) | ||
| if result.GetErrorSize() > 0: |
There was a problem hiding this comment.
Btw there is some GetStatus(SBCommandReturnObject self) -> lldb::ReturnStatus - do we maybe need to use it?
| "remote-file", | ||
| "symfile", | ||
| "version", | ||
| ] | ||
|
|
||
|
|
||
| def _get_target_triple(debugger: lldb.SBDebugger, filepath: str) -> str | None: | ||
| target: lldb.SBTarget = debugger.CreateTarget(filepath) |
There was a problem hiding this comment.
Pls add a docstring with info/examples what a target triple is, what it can be (e.g. "a-b-c" etc).
disconnect3d
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.