Dont redundantly scalafmt on compile #1135
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This opts for checking scalafmt when a PR is opened rather than doing it on compile. This can be considered a subjective change however here is my personal reasoning
Note that the PR removes using
scalafmt
inci.yaml
and instead creates it as a separate pipeline that uses scalafmt-native. This has the following advantagesNote that I have submitted this kind of scalafmt checking on numerous Scala projects and there haven't been any issues.