Skip to content

Commit

Permalink
Fix CODEOWNER regex to include devx and phoenix
Browse files Browse the repository at this point in the history
When PRs are raised the CODEOWNERS.md is assessed via regex to determine the allowed approvers. The     CODEOWNERS file uses the last matching pattern for each file. In this case, there are two patterns t    hat match all files, and the last one is "@puppetlabs/phoenix". This is why only the Phoenix team is     being requested for review.  To have both teams requested for review, the regex needs to be in one     line like this: "@puppetlabs/devx @puppetlabs/phoenix". This way, both teams will be automatically r    equested for review when a pull request is opened.

Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
  • Loading branch information
gavindidrichsen committed Dec 20, 2023
1 parent 8b51d94 commit 2d6a915
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
# Set the DevX team as the primary owners of the Tool
* @puppetlabs/devx
* @puppetlabs/phoenix
* @puppetlabs/devx @puppetlabs/phoenix

0 comments on commit 2d6a915

Please sign in to comment.