Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(page): mark page.client() as internal #7585

Merged
merged 1 commit into from
Sep 21, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions docs/api.md
Original file line number Diff line number Diff line change
@@ -133,7 +133,6 @@
* [page.browser()](#pagebrowser)
* [page.browserContext()](#pagebrowsercontext)
* [page.click(selector[, options])](#pageclickselector-options)
* [page.client()](#pageclient)
* [page.close([options])](#pagecloseoptions)
* [page.content()](#pagecontent)
* [page.cookies([...urls])](#pagecookiesurls)
@@ -1466,12 +1465,6 @@ const [response] = await Promise.all([

Shortcut for [page.mainFrame().click(selector[, options])](#frameclickselector-options).

#### page.client()

- returns: <[CDPSession]>

Get the CDP session client the page belongs to.

#### page.close([options])

- `options` <[Object]>
1 change: 1 addition & 0 deletions src/common/Page.ts
Original file line number Diff line number Diff line change
@@ -731,6 +731,7 @@ export class Page extends EventEmitter {

/**
* Get the CDP session client the page belongs to.
* @internal
*/
client(): CDPSession {
return this._client;
1 change: 1 addition & 0 deletions utils/doclint/check_public_api/index.js
Original file line number Diff line number Diff line change
@@ -25,6 +25,7 @@ const {
const EXCLUDE_PROPERTIES = new Set([
'Browser.create',
'Headers.fromPayload',
'Page.client',
'Page.create',
'JSHandle.toString',
'TimeoutError.name',