Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill PhantomShim. #533

Merged
merged 4 commits into from
Aug 25, 2017
Merged

Kill PhantomShim. #533

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c820c7
Kill PhantomShim.
aslushnikov Aug 25, 2017
5b159b0
kill entries from npmignore
aslushnikov Aug 25, 2017
6f4cfc5
Bring back the `npm run build` command
aslushnikov Aug 25, 2017
d1fba73
proper revert
aslushnikov Aug 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
proper revert
  • Loading branch information
@aslushnikov
aslushnikov authored Aug 25, 2017
commit d1fba736aeab702b57ce30b05628e39e06c6ca69
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
"coverage": "COVERAGE=true npm run unit",
"node6": "node utils/node6-transform/index.js",
"test-node6": "jasmine utils/node6-transform/test/test.js",
"node6-sanity": "jasmine test/sanity.js",
"build": "npm run node6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was unintentional removal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a drive-by. Do we need it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to future proof, in case we have more build steps.

"node6-sanity": "jasmine test/sanity.js"
},
"author": "The Chromium Authors",
"license": "SEE LICENSE IN LICENSE",
Expand Down