feat: add unpacking indicator to the install command #13356
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Lightning00Blade
changed the title
| if (downloadedBytes >= totalBytes && !isExtracting) { | ||
| // Transition to the extraction phase | ||
| progressBar.terminate(); // Clear download progress bar | ||
| console.log(`Extracting ${browser} ${buildId}...`); // Simple console message for now |
There was a problem hiding this comment.
I believe this would report extracting even when no extracting is happening (options.unpack === false) and also it would not cover the waiting for running setup and installing deps (options.installDeps === true).
We probably also should not use console.log directly as the progress bar is only rendering if the output stream isTTY.
I think using a static message is fine but we should also write it to process.stderr as the progress bar and we can add messages directly to the corresponding code that does extraction/deps/setup conditions on the presence of downloadProgressBar that indicates whether the code is invoked from CLI.
Summary of Updates in CLI.ts:
Enhanced error handling and logging for improved user feedback during CLI operations.
Streamlined argument parsing for clarity and efficiency.
Added debug messages for tracking command execution and potential failures.
Optimized the CLI workflow to handle edge cases and ensure robust functionality.
Bug: #13083