chore: update Expectations #11341
Closed
chore: update Expectations #11341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf-2
approved these changes
Nov 9, 2023
Lightning00Blade
force-pushed
the
fix-firefox-expectations
branch
2 times, most recently
from
370b5e5 to
a68d39d
Compare
OrKoN
reviewed
Nov 9, 2023
| @@ -911,6 +911,12 @@ | |||
| "parameters": ["webDriverBiDi"], | |||
| "expectations": ["FAIL"] | |||
| }, | |||
| { | |||
| "testIdPattern": "[oopif.spec] OOPIF should support OOP iframes getting detached", | |||
There was a problem hiding this comment.
I think it would be easier to just flip FF expectations that were marked FAIL to be PASS
OrKoN
force-pushed
the
fix-firefox-expectations
branch
from
7a56cfd to
450a56c
Compare
|
Updated Firefox in #11346 but it would be good to figure out the Chrome failures here |
|
Note: There are test that are now passing but even after #11346 they are skippped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.