Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppeteer/puppeteer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v13.3.2
Choose a base ref
...
head repository: puppeteer/puppeteer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Loading
Showing 4,292 changed files with 247,948 additions and 112,617 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
12 changes: 12 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"image": "mcr.microsoft.com/devcontainers/universal:2",
"features": {
"ghcr.io/devcontainers/features/node:1": {
"version": "18"
},
"ghcr.io/devcontainers/features/docker-in-docker:1": {
"version": "latest",
"moby": true
}
}
}
17 changes: 0 additions & 17 deletions .eslintignore

This file was deleted.

185 changes: 0 additions & 185 deletions .eslintrc.js

This file was deleted.

135 changes: 102 additions & 33 deletions .github/ISSUE_TEMPLATE/bug.yml
Original file line number Diff line number Diff line change
@@ -1,58 +1,127 @@
name: Bug report
description: File a bug report
description: File a bug report for puppeteer or puppeteer-core
title: '[Bug]: '
labels: [bug]
body:
- type: markdown
attributes:
value: |
Thanks for taking the time to fill out this bug report!
- type: textarea
id: summary
value: >
### Thanks for taking the time to fill out this bug report!
**Before filling out this report**, please check our
[Troubleshooting](https://pptr.dev/troubleshooting) guide for solutions
to common issues.
If your issue is not about `puppeteer` or `puppeteer-core` packages, check out
other issue templates at https://github.com/puppeteer/puppeteer/issues/new/choose.
- id: mvce
type: textarea
attributes:
label: Bug description
description: What did you do? What did you expect to happen? What actually happened instead?
value: |
Steps to reproduce the problem:
label: Minimal, reproducible example
description: >
Provide a [minimal, reproducible
example](https://stackoverflow.com/help/minimal-reproducible-example) of
the bug you are facing. If possible, embedd the test page content into the
Puppeteer script using `page.setContent()`.
render: TypeScript
placeholder: |
import puppeteer from 'puppeteer';
const browser = await puppeteer.launch();
const page = await browser.newPage();
1. …
// Set test content.
await page.setContent(`<div>test</div>`);
// Actions to trigger the bug.
await browser.close();
validations:
required: true
- id: background
type: textarea
attributes:
label: Background
description: >
Optional. Briefly describe your use-case that led to this issue. This can help us
understand the general situation to provide better, higher quality
feedback and help others in similar situations.
placeholder: |
I've been trying to ...
- id: expectation
type: textarea
attributes:
label: Expectation
description: What are you expecting the code to do?
placeholder: |
I expected ...
validations:
required: true
- id: reality
type: textarea
attributes:
label: Reality
description: What actually happens?
placeholder: |
In reality, ...
validations:
required: true
- type: input
id: puppeteer-version
- id: puppeteer-configuration
type: textarea
attributes:
label: Puppeteer configuration file (if used)
description: >
Copy and paste your [configuration
file](https://pptr.dev/guides/configuration/) (if used).
*No need for backticks — this automatically gets formatted into code.*
render: TypeScript
- id: puppeteer-version
type: input
attributes:
label: Puppeteer version
description: What version of Puppeteer are you running?
description: >
What version of Puppeteer are you running? *This must be a valid semver
tag, for example, `20.8.1`.*
validations:
required: true
- id: node-version
type: input
attributes:
label: Node version
description: >
What supported version of Node.js are you running? *This must be a valid
semver tag, for example, `20.3.1`.*
validations:
required: true
- type: input
id: node-version
- id: pkg-mgr
type: dropdown
attributes:
label: Node.js version
description: What version of Node.js are you running?
label: Package manager
description: What package manager are you running?
options:
- npm
- yarn
- pnpm
validations:
required: true
- type: input
id: npm-version
- id: pkg-mgr-version
type: input
attributes:
label: npm version
description: What version of npm are you running?
label: Package manager version
description: >
What version of the package manager are you running? *This must be a
valid semver tag, for example, `9.6.7`.*
validations:
required: true
- type: dropdown
id: operating-system
- id: operating-system
type: dropdown
attributes:
label: What operating system are you seeing the problem on?
multiple: true
label: Operating system
description: What supported operating system are you running?
options:
- Linux
- macOS
- Windows
- macOS
- Linux
validations:
required: true
- type: textarea
id: logs
attributes:
label: Relevant log output
description: Please copy and paste any relevant log output. No need for backticks — this automatically gets formatted into code.
render: shell
17 changes: 17 additions & 0 deletions .github/ISSUE_TEMPLATE/feature.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: Feature
description: File a feature request
title: '[Feature]: '
labels: [feature]
body:
- type: markdown
attributes:
value: |
### Thanks for taking the time to fill out a feature request!
**Before filling out this report**, please check [existing feature requests](https://github.com/puppeteer/puppeteer/issues?q=is%3Aissue++label%3Afeature+) and see if your feature has already been proposed.
- type: textarea
id: summary
attributes:
label: Feature description
description: Please describe your feature request with as many details as possible.
validations:
required: true
Loading