Kill PhantomShim. (#533)

This patch kills PhantomShim, a lightweight layer that helped to bootstrap Puppeteer API. At this point, PhantomShim: - passes 139 phantomJS tests - fails 13 tests - lacks capabilities to run 26 The failings and unsupported tests don't have any value for Puppeteer API, so it doesn't make sense to maintain PhantomShim any longer.
puppeteer · Aug 25, 2017 · e8f8a1a · e8f8a1a
1 parent 2c4dfbf
commit e8f8a1a
Show file tree

Hide file tree

Showing 216 changed files with 0 additions and 21,793 deletions.
diff --git a/.npmignore b/.npmignore
@@ -1,7 +1,3 @@
-# exclude phantomjs tests
-third_party/phantomjs/
-# exclude phantom_shim project
-phantom_shim
 # exclude all tests
 test
 utils/node6-transform

diff --git a/.travis.yml b/.travis.yml
@@ -15,7 +15,6 @@ install:
 script:
   - 'if [ "$NODE7" = "true" ]; then yarn run lint; fi'
   - 'if [ "$NODE7" = "true" ]; then yarn run coverage; fi'
-  - 'if [ "$NODE7" = "true" ]; then yarn run test-phantom; fi'
   - 'if [ "$NODE6" = "true" ]; then yarn run node6; fi'
   - 'if [ "$NODE6" = "true" ]; then yarn run test-node6; fi'
   - 'if [ "$NODE6" = "true" ]; then yarn run node6-sanity; fi'

diff --git a/package.json b/package.json
@@ -10,7 +10,6 @@
   "scripts": {
     "unit": "jasmine test/test.js",
     "debug-unit": "DEBUG_TEST=true node --inspect-brk ./node_modules/.bin/jasmine test/test.js",
-    "test-phantom": "python third_party/phantomjs/test/run-tests.py",
     "test-doclint": "jasmine utils/doclint/check_public_api/test/test.js && jasmine utils/doclint/preprocessor/test.js",
     "test": "npm run lint --silent && npm run coverage && npm run test-phantom && npm run test-doclint && npm run test-node6",
     "install": "node install.js",

diff --git a/phantom_shim/FileSystem.js b/phantom_shim/FileSystem.js