Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pye3d plugin colors consistent #2136

Merged
merged 3 commits into from
Apr 22, 2021
Merged

Make pye3d plugin colors consistent #2136

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38814f4
Extract pye3d plugin visualization color constants
romanroibu Apr 18, 2021
7e5c6be
Update pye3d plugin visualization colors
romanroibu Apr 18, 2021
13e7890
Always draw pye3d plugin's pupil outline
romanroibu Apr 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Always draw pye3d plugin's pupil outline
  • Loading branch information
@romanroibu
romanroibu committed Apr 18, 2021
commit 13e78902f6ba9e257f8e094bbb91d67472c9a575
10 changes: 7 additions & 3 deletions pupil_src/shared_modules/pupil_detector_plugins/pye3d_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,14 +192,14 @@ def init_ui(self):
def gl_display(self):
self.debug_window_update()
result = self._recent_detection_result

if result is not None:
if not self.is_debug_window_open:
# normal drawing
# normal eyeball drawing
draw_eyeball_outline(result)
draw_pupil_outline(result)

elif "debug_info" in result:
# debug drawing
# debug eyeball drawing
debug_info = result["debug_info"]
draw_ellipse(
ellipse=debug_info["projected_ultra_long_term"],
Expand All @@ -216,6 +216,10 @@ def gl_display(self):
rgba=self.COLOR_SHORT_TERM_MODEL,
thickness=2,
)

# always draw pupil
draw_pupil_outline(result)

if self.__debug_window_button:
self.__debug_window_button.label = self.__debug_window_button_label

Expand Down