Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle PI recordings with broken video #2077

Merged
merged 9 commits into from
Jan 11, 2021
Merged

Gracefully handle PI recordings with broken video #2077

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c68d50d
Merge pull request #2075 from pupil-labs/develop
papr Dec 10, 2020
1b404ff
Gracefully handle loading audio stream from a broken container
romanroibu Dec 17, 2020
f2190e2
Rewrite world timestamps file for PI if the video is broken
romanroibu Dec 17, 2020
073a5b9
Add video and raw time files rewriting for affected recordings
romanroibu Dec 31, 2020
19d829e
Sort imports
papr Jan 4, 2021
58bfb33
Close container to avoid corrupt result
papr Jan 4, 2021
9dba7f3
Use shutil.move over Path.replace
papr Jan 4, 2021
e563050
Remove debug suffix
papr Jan 4, 2021
23826a4
Handle non-video streams when fixing broken frame issue
romanroibu Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Handle non-video streams when fixing broken frame issue
  • Loading branch information
@romanroibu
romanroibu committed Jan 5, 2021
commit 23826a4e70b8b2af281318e9b3cd2ee7e9902ee2
26 changes: 19 additions & 7 deletions pupil_src/shared_modules/pupil_recording/update/invisible.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,14 +204,26 @@ def patch_recording_if_affected(cls, recording: PupilRecording):

# Save video, dropping first frame, to temp file
in_container = av.open(str(v_path))
in_video_stream = in_container.streams.video[0]
out_container = av.open(str(temp_v_path), "w")
out_container.add_stream(template=in_video_stream)
out_video_stream = out_container.streams.video[0]
packets = in_container.demux(video=0)
_ = next(packets) # Drop first
for packet in packets:
packet.stream = out_video_stream

# input -> output stream mapping
stream_mapping = {
in_stream: out_container.add_stream(template=in_stream)
for in_stream in in_container.streams
}

# Keep track of streams that should skip frame
stream_should_skip_frame = {
in_stream: in_stream.codec_context.type == "video"
for in_stream in stream_mapping.keys()
}

for packet in in_container.demux():
if stream_should_skip_frame[packet.stream]:
# Once the stream skipped the first frame, don't skip anymore
stream_should_skip_frame[packet.stream] = False
continue
packet.stream = stream_mapping[packet.stream]
out_container.mux(packet)
out_container.close()

Expand Down