Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support localhost integration in ssl_bind #2711

Closed
wants to merge 4 commits into from
Closed

Support localhost integration in ssl_bind #2711

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e3a05b0
Support localhost integratin in ssl_bind
Sep 23, 2021
2f41a31
Feedback changes
Oct 1, 2021
1d3f775
Add test
Oct 4, 2021
33cc92a
Update tests
Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update tests
  • Loading branch information
Marcin Olichwirowicz committed Oct 4, 2021
commit 33cc92ae1e5bbfb65e3cbb9f81baf656d4b91692
6 changes: 4 additions & 2 deletions test/test_integration_ssl.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def setup
RUBY

@localhost_config = <<RUBY
require 'localhost/authority'
require 'localhost'

ssl_bind '#{HOST}', '#{@bind_port}'

Expand Down Expand Up @@ -104,6 +104,8 @@ def test_ssl_run
end

def test_ssl_run_with_localhost_authority
skip_if :jruby

body = nil
start_server("#{BASE} bin/puma -C #{generate_config(@localhost_config)}")
@http.start do
Expand All @@ -112,5 +114,5 @@ def test_ssl_run_with_localhost_authority
end
assert_equal 'https', body
stop_server
end unless ::Puma::IS_JRUBY
end
end if ::Puma::HAS_SSL