Ensure we return all yargs parsed parameters

pulsar-edit · confused-Techie · Jul 23, 2023 · Jul 22, 2023 · Jul 22, 2023 · Jul 22, 2023
commit 6c10eec919072fdfb06cdb2e89a6ddeba3267031
diff --git a/src/ci.js b/src/ci.js
@@ -34,7 +34,7 @@ but cannot be used to install new packages or dependencies.\
 );
 
     options.alias('h', 'help').describe('help', 'Print this usage message');
-    options.boolean('verbose').default('verbose', false).describe('verbose', 'Show verbose debug information');
+    return options.boolean('verbose').default('verbose', false).describe('verbose', 'Show verbose debug information');
   }
 
   installModules(options, callback) {
@@ -73,7 +73,7 @@ but cannot be used to install new packages or dependencies.\
     commands.push(callback => { return config.loadNpm((error, npm) => { this.npm = npm; return callback(error); }); });
     commands.push(cb => this.loadInstalledAtomMetadata(cb));
     commands.push(cb => this.installModules(opts, cb));
-
+    throw new Error(options.argv);
     const iteratee = (item, next) => item(next);
     return async.mapSeries(commands, iteratee, function(err) {
       if (err) { return callback(err); }

diff --git a/src/clean.js b/src/clean.js
@@ -30,7 +30,7 @@ Deletes all packages in the node_modules folder that are not referenced
 as a dependency in the package.json file.\
 `
     );
-    options.alias('h', 'help').describe('help', 'Print this usage message');
+    return options.alias('h', 'help').describe('help', 'Print this usage message');
   }
 
   run(options) {

diff --git a/src/config.js b/src/config.js
@@ -28,7 +28,7 @@ Usage: ppm config set <key> <value>
 \
 `
     );
-    options.alias('h', 'help').describe('help', 'Print this usage message');
+    return options.alias('h', 'help').describe('help', 'Print this usage message');
   }
 
   run(options) {

diff --git a/src/dedupe.js b/src/dedupe.js
@@ -32,7 +32,7 @@ Reduce duplication in the node_modules folder in the current directory.
 This command is experimental.\
 `
       );
-      soptions.alias('h', 'help').describe('help', 'Print this usage message');
+      return options.alias('h', 'help').describe('help', 'Print this usage message');
     }
 
     dedupeModules(options, callback) {

diff --git a/src/develop.js b/src/develop.js
@@ -41,7 +41,7 @@ Once this command completes you can open a dev window from atom using
 cmd-shift-o to run the package out of the newly cloned repository.\
 `
       );
-      options.alias('h', 'help').describe('help', 'Print this usage message');
+      return options.alias('h', 'help').describe('help', 'Print this usage message');
     }
 
     getRepositoryUrl(packageName, callback) {

diff --git a/src/disable.js b/src/disable.js
@@ -21,7 +21,7 @@ Usage: ppm disable [<package_name>]...
 Disables the named package(s).\
 `
       );
-      options.alias('h', 'help').describe('help', 'Print this usage message');
+      return options.alias('h', 'help').describe('help', 'Print this usage message');
     }
 
     getInstalledPackages(callback) {

diff --git a/src/docs.js b/src/docs.js
@@ -19,7 +19,7 @@ Open a package's homepage in the default browser.\
 `
       );
       options.alias('h', 'help').describe('help', 'Print this usage message');
-      options.boolean('p').alias('p', 'print').describe('print', 'Print the URL instead of opening it');
+      return options.boolean('p').alias('p', 'print').describe('print', 'Print the URL instead of opening it');
     }
 
     openRepositoryUrl(repositoryUrl) {

diff --git a/src/enable.js b/src/enable.js
@@ -20,7 +20,7 @@ Usage: ppm enable [<package_name>]...
 Enables the named package(s).\
 `
       );
-      options.alias('h', 'help').describe('help', 'Print this usage message');
+      return options.alias('h', 'help').describe('help', 'Print this usage message');
     }
 
     run(options) {

diff --git a/src/featured.js b/src/featured.js
@@ -25,7 +25,7 @@ List the Pulsar packages and themes that are currently featured.\
       options.alias('h', 'help').describe('help', 'Print this usage message');
       options.alias('t', 'themes').boolean('themes').describe('themes', 'Only list themes');
       options.alias('c', 'compatible').string('compatible').describe('compatible', 'Only list packages/themes compatible with this Pulsar version');
-      options.boolean('json').describe('json', 'Output featured packages as JSON array');
+      return options.boolean('json').describe('json', 'Output featured packages as JSON array');
     }
 
     getFeaturedPackagesByType(atomVersion, packageType, callback) {

diff --git a/src/init.js b/src/init.js
@@ -39,7 +39,7 @@ on the option selected.\
       options.alias('l', 'language').string('language').describe('language', 'Generates a basic language package');
       options.alias('c', 'convert').string('convert').describe('convert', 'Path or URL to TextMate bundle/theme to convert');
       options.alias('h', 'help').describe('help', 'Print this usage message');
-      options.string('template').describe('template', 'Path to the package or theme template');
+      return options.string('template').describe('template', 'Path to the package or theme template');
     }
 
     run(options) {

diff --git a/src/install.js b/src/install.js
@@ -64,7 +64,7 @@ package names to install with optional versions using the
       options.boolean('check').describe('check', 'Check that native build tools are installed');
       options.boolean('verbose').default('verbose', false).describe('verbose', 'Show verbose debug information');
       options.string('packages-file').describe('packages-file', 'A text file containing the packages to install');
-      options.boolean('production').describe('production', 'Do not install dev dependencies');
+      return options.boolean('production').describe('production', 'Do not install dev dependencies');
     }
 
     installModule(options, pack, moduleURI, callback) {

diff --git a/src/link.js b/src/link.js
@@ -25,7 +25,7 @@ Run \`ppm links\` to view all the currently linked packages.\
 `
       );
       options.alias('h', 'help').describe('help', 'Print this usage message');
-      options.alias('d', 'dev').boolean('dev').describe('dev', 'Link to ~/.pulsar/dev/packages');
+      return options.alias('d', 'dev').boolean('dev').describe('dev', 'Link to ~/.pulsar/dev/packages');
     }
 
     run(options) {

diff --git a/src/links.js b/src/links.js
@@ -28,7 +28,7 @@ List all of the symlinked atom packages in ~/.atom/packages and
 ~/.pulsar/dev/packages.\
 `
       );
-      options.alias('h', 'help').describe('help', 'Print this usage message');
+      return options.alias('h', 'help').describe('help', 'Print this usage message');
     }
 
     getDevPackagePath(packageName) { return path.join(this.devPackagesPath, packageName); }

diff --git a/src/list.js b/src/list.js
@@ -53,7 +53,7 @@ List all the installed packages and also the packages bundled with Atom.\
       options.alias('l', 'links').boolean('links').default('links', true).describe('links', 'Include linked packages');
       options.alias('t', 'themes').boolean('themes').describe('themes', 'Only list themes');
       options.alias('p', 'packages').boolean('packages').describe('packages', 'Only list packages');
-      options.alias('v', 'versions').boolean('versions').default('versions', true).describe('versions', 'Include version of each package');
+      return options.alias('v', 'versions').boolean('versions').default('versions', true).describe('versions', 'Include version of each package');
     }
 
     isPackageDisabled(name) {

diff --git a/src/login.js b/src/login.js
@@ -40,7 +40,7 @@ be used to identify you when publishing packages.\
 `
       );
       options.alias('h', 'help').describe('help', 'Print this usage message');
-      options.string('token').describe('token', 'Package API token');
+      return options.string('token').describe('token', 'Package API token');
     }
 
     run(options) {

diff --git a/src/publish.js b/src/publish.js
@@ -51,7 +51,7 @@ have published it.\
       );
       options.alias('h', 'help').describe('help', 'Print this usage message');
       options.alias('t', 'tag').string('tag').describe('tag', 'Specify a tag to publish. Must be of the form vx.y.z');
-      options.alias('r', 'rename').string('rename').describe('rename', 'Specify a new name for the package');
+      return options.alias('r', 'rename').string('rename').describe('rename', 'Specify a new name for the package');
     }
 
     // Create a new version and tag use the `npm version` command.

diff --git a/src/rebuild-module-cache.js b/src/rebuild-module-cache.js
@@ -30,7 +30,7 @@ at the _atomModuleCache property in the package's package.json file.
 This command skips all linked packages.\
 `
       );
-      options.alias('h', 'help').describe('help', 'Print this usage message');
+      return options.alias('h', 'help').describe('help', 'Print this usage message');
     }
 
     getResourcePath(callback) {

diff --git a/src/rebuild.js b/src/rebuild.js
@@ -32,7 +32,7 @@ in the current working directory.
 All the modules will be rebuilt if no module names are specified.\
 `
       );
-      options.alias('h', 'help').describe('help', 'Print this usage message');
+      return options.alias('h', 'help').describe('help', 'Print this usage message');
     }
 
     forkNpmRebuild(options, callback) {

diff --git a/src/search.js b/src/search.js
@@ -25,7 +25,7 @@ Search for packages/themes.\
       options.alias('h', 'help').describe('help', 'Print this usage message');
       options.boolean('json').describe('json', 'Output matching packages as JSON array');
       options.boolean('packages').describe('packages', 'Search only non-theme packages').alias('p', 'packages');
-      options.boolean('themes').describe('themes', 'Search only themes').alias('t', 'themes');
+      return options.boolean('themes').describe('themes', 'Search only themes').alias('t', 'themes');
     }
 
     searchPackages(query, opts, callback) {

diff --git a/src/star.js b/src/star.js
@@ -29,7 +29,7 @@ Run \`ppm stars\` to see all your starred packages.\
 `
       );
       options.alias('h', 'help').describe('help', 'Print this usage message');
-      options.boolean('installed').describe('installed', 'Star all packages in ~/.pulsar/packages');
+      return options.boolean('installed').describe('installed', 'Star all packages in ~/.pulsar/packages');
     }
 
     starPackage(packageName, param, callback) {

diff --git a/src/stars.js b/src/stars.js
@@ -29,7 +29,7 @@ List or install starred Atom packages and themes.\
       options.alias('i', 'install').boolean('install').describe('install', 'Install the starred packages');
       options.alias('t', 'themes').boolean('themes').describe('themes', 'Only list themes');
       options.alias('u', 'user').string('user').describe('user', 'GitHub username to show starred packages for');
-      options.boolean('json').describe('json', 'Output packages as a JSON array');
+      return options.boolean('json').describe('json', 'Output packages as a JSON array');
     }
 
     getStarredPackages(user, atomVersion, callback) {

diff --git a/src/test.js b/src/test.js
@@ -23,7 +23,7 @@ to the current working directory).\
 `
       );
       options.alias('h', 'help').describe('help', 'Print this usage message');
-      options.alias('p', 'path').string('path').describe('path', 'Path to atom command');
+      return options.alias('p', 'path').string('path').describe('path', 'Path to atom command');
     }
 
     run(options) {

diff --git a/src/uninstall.js b/src/uninstall.js
@@ -26,7 +26,7 @@ Delete the installed package(s) from the ~/.pulsar/packages directory.\
       );
       options.alias('h', 'help').describe('help', 'Print this usage message');
       options.alias('d', 'dev').boolean('dev').describe('dev', 'Uninstall from ~/.pulsar/dev/packages');
-      options.boolean('hard').describe('hard', 'Uninstall from ~/.pulsar/packages and ~/.pulsar/dev/packages');
+      return options.boolean('hard').describe('hard', 'Uninstall from ~/.pulsar/packages and ~/.pulsar/dev/packages');
     }
 
     getPackageVersion(packageDirectory) {

diff --git a/src/unlink.js b/src/unlink.js
@@ -33,7 +33,7 @@ Run \`ppm links\` to view all the currently linked packages.\
       options.alias('h', 'help').describe('help', 'Print this usage message');
       options.alias('d', 'dev').boolean('dev').describe('dev', 'Unlink package from ~/.pulsar/dev/packages');
       options.boolean('hard').describe('hard', 'Unlink package from ~/.pulsar/packages and ~/.pulsar/dev/packages');
-      options.alias('a', 'all').boolean('all').describe('all', 'Unlink all packages in ~/.pulsar/packages and ~/.pulsar/dev/packages');
+      return options.alias('a', 'all').boolean('all').describe('all', 'Unlink all packages in ~/.pulsar/packages and ~/.pulsar/dev/packages');
     }
 
     getDevPackagePath(packageName) { return path.join(this.devPackagesPath, packageName); }

diff --git a/src/unpublish.js b/src/unpublish.js
@@ -28,7 +28,7 @@ name is specified.\
 `
       );
       options.alias('h', 'help').describe('help', 'Print this usage message');
-      options.alias('f', 'force').boolean('force').describe('force', 'Do not prompt for confirmation');
+      return options.alias('f', 'force').boolean('force').describe('force', 'Do not prompt for confirmation');
     }
 
     unpublishPackage(packageName, packageVersion, callback) {

diff --git a/src/unstar.js b/src/unstar.js
@@ -22,7 +22,7 @@ Unstar the given packages
 Run \`ppm stars\` to see all your starred packages.\
 `
       );
-      options.alias('h', 'help').describe('help', 'Print this usage message');
+      return options.alias('h', 'help').describe('help', 'Print this usage message');
     }
 
     starPackage(packageName, token, callback) {

diff --git a/src/upgrade.js b/src/upgrade.js
@@ -46,7 +46,7 @@ available updates.\
       options.alias('l', 'list').boolean('list').describe('list', 'List but don\'t install the outdated packages');
       options.boolean('json').describe('json', 'Output outdated packages as a JSON array');
       options.string('compatible').describe('compatible', 'Only list packages/themes compatible with this Atom version');
-      options.boolean('verbose').default('verbose', false).describe('verbose', 'Show verbose debug information');
+      return options.boolean('verbose').default('verbose', false).describe('verbose', 'Show verbose debug information');
     }
 
     getInstalledPackages(options) {

diff --git a/src/view.js b/src/view.js
@@ -23,7 +23,7 @@ View information about a package/theme.\
       );
       options.alias('h', 'help').describe('help', 'Print this usage message');
       options.boolean('json').describe('json', 'Output featured packages as JSON array');
-      options.string('compatible').describe('compatible', 'Show the latest version compatible with this Atom version');
+      return options.string('compatible').describe('compatible', 'Show the latest version compatible with this Atom version');
     }
 
     loadInstalledAtomVersion(options, callback) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -28,7 +28,7 @@ Usage: ppm config set <key> <value> @@
     \
     `
         );
-        options.alias('h', 'help').describe('help', 'Print this usage message');
+        return options.alias('h', 'help').describe('help', 'Print this usage message');
       }
       run(options) {
@@ Expand Down @@