Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Less Syntax #34

Merged
merged 4 commits into from
Jul 16, 2023
Merged

Fix Less Syntax #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d9093f
A few files
confused-Techie Jul 16, 2023
e216922
Additional few files
confused-Techie Jul 16, 2023
9cf2beb
styles: Fix some less syntax that's invalid in Less 4.x
DeeDeeG Jul 16, 2023
e6b69d7
Add the rest of the files for wrapping math in `()`
confused-Techie Jul 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions styles/accordion.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
&-header {
font-weight: 600;
color: @text-color-subtle;
padding: @component-padding/2;
padding: (@component-padding/2);
border-bottom: 1px solid @base-border-color;
display: flex;
align-items: center;
Expand Down Expand Up @@ -48,7 +48,7 @@
&-listItem {
display: flex;
align-items: center;
padding: @component-padding / 4;
padding: (@component-padding / 4);
border-bottom: 1px solid @base-border-color;

&:last-child {
Expand Down
6 changes: 3 additions & 3 deletions styles/branch-menu-view.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
}

&-item {
margin: @component-padding / 2;
margin: (@component-padding / 2);
}

.icon-sync::before {
Expand Down Expand Up @@ -64,8 +64,8 @@

&-message {
max-height: 20em;
margin: @component-padding / 2;
padding: @component-padding / 2;
margin: (@component-padding / 2);
padding: (@component-padding / 2);
line-height: 1.4;
white-space: normal;
text-align: left;
Expand Down
2 changes: 1 addition & 1 deletion styles/cache-view.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
}

td {
padding: @component-padding / 2;
padding: (@component-padding / 2);
vertical-align: top;
}

Expand Down
6 changes: 3 additions & 3 deletions styles/co-author-form.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
display: flex;
flex-direction: column;
margin-top: @component-padding;
padding: @component-padding/2;
padding: (@component-padding/2);
border-radius: @component-border-radius @component-border-radius 0 0;
border: 1px solid @base-border-color;
border-bottom: 0;
Expand All @@ -13,14 +13,14 @@
&-row {
display: flex;
align-items: center;
margin: @component-padding/2;
margin: (@component-padding/2);

&.has-buttons {
margin: 0;
flex-wrap: wrap;
.btn {
flex: 1;
margin: @component-padding/2;
margin: (@component-padding/2);
}
.btn-primary {
flex: 4;
Expand Down
10 changes: 5 additions & 5 deletions styles/commit-detail.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
}

&-commit {
padding: @default-padding*2;
padding: (@default-padding*2);
padding-bottom: 0;
}

Expand All @@ -36,12 +36,12 @@
&-meta {
display: flex;
align-items: center;
margin: @default-padding/2 0 @default-padding*2 0;
margin: (@default-padding/2) 0 (@default-padding*2) 0;
}

&-metaText {
flex: 1;
margin-left: @avatar-dimensions * 1.4; // leave some space for the avatars
margin-left: (@avatar-dimensions * 1.4); // leave some space for the avatars
line-height: @avatar-dimensions;
color: @text-color-subtle;
}
Expand All @@ -63,7 +63,7 @@
}

&-moreText {
padding: @default-padding*2 0;
padding: (@default-padding*2) 0;
font-size: inherit;
font-family: var(--editor-font-family);
word-wrap: initial;
Expand All @@ -81,7 +81,7 @@

&-sha {
flex: 0 0 7ch; // Limit to 7 characters
margin-left: @default-padding*2;
margin-left: (@default-padding*2);
line-height: @avatar-dimensions;
color: @text-color-subtle;
font-family: var(--editor-font-family);
Expand Down
12 changes: 6 additions & 6 deletions styles/commit-view.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
position: relative;
border: 1px solid @input-border-color;
border-radius: @component-border-radius;
padding: @component-padding / 2;
padding: (@component-padding / 2);
font-size: @font-size;
background-color: @syntax-background-color;

Expand Down Expand Up @@ -47,7 +47,7 @@
position: absolute;
left: 0;
bottom: 0;
padding: @component-padding / 2;
padding: (@component-padding / 2);
line-height: 1;
border: none;
background-color: @syntax-background-color;
Expand Down Expand Up @@ -89,7 +89,7 @@

&-coAuthorEditor {
position: relative;
margin-top: @component-padding / 2;
margin-top: (@component-padding / 2);
padding: (@component-padding / 4) (@component-padding / 2);
border: 1px solid @base-border-color;
color: @syntax-text-color;
Expand Down Expand Up @@ -164,7 +164,7 @@
background-color: transparent;
width: 100%;

padding: @component-padding / 2;
padding: (@component-padding / 2);
padding-right: 10px; // space for scrollbar
border-top: 1px solid @overlay-border-color;
white-space: nowrap;
Expand Down Expand Up @@ -210,7 +210,7 @@
position: absolute;
right: 0;
bottom: 0;
padding: @component-padding / 2;
padding: (@component-padding / 2);
line-height: 1;
border: none;
background-color: @syntax-background-color;
Expand Down Expand Up @@ -273,7 +273,7 @@
background-color: transparent;
opacity: .5;
&::before {
margin-right: @component-padding / 2;
margin-right: (@component-padding / 2);
}
&::after {
content: "Toggle expanded commit message";
Expand Down
10 changes: 5 additions & 5 deletions styles/conflicting-editor.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ atom-text-editor {
display: flex;
align-items: center;
margin-right: @component-padding;
padding: @component-padding / 2;
padding: (@component-padding / 2);
cursor: default;
color: fade(@syntax-text-color, 75%);

Expand All @@ -40,13 +40,13 @@ atom-text-editor {

.github-ConflictTopBlock {
margin-top: @component-padding;
border-top-left-radius: @component-border-radius * 1.5;
border-top-right-radius: @component-border-radius * 1.5;
border-top-left-radius: (@component-border-radius * 1.5);
border-top-right-radius: (@component-border-radius * 1.5);
}
.github-ConflictBottomBlock {
margin-bottom: @component-padding;
border-bottom-left-radius: @component-border-radius * 1.5;
border-bottom-right-radius: @component-border-radius * 1.5;
border-bottom-left-radius: (@component-border-radius * 1.5);
border-bottom-right-radius: (@component-border-radius * 1.5);
}


Expand Down
14 changes: 7 additions & 7 deletions styles/dialog.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@import "variables";

@github-dialog-spacing: @component-padding / 2;
@github-dialog-spacing: (@component-padding / 2);

.github-Dialog {
&Prompt {
Expand Down Expand Up @@ -186,7 +186,7 @@

&Avatar {
flex: 0;
border-radius: @component-padding/4;
border-radius: (@component-padding/4);
margin: 0 @component-padding 0 0;
}

Expand Down Expand Up @@ -238,7 +238,7 @@
&Option {
display: inline-flex;
align-items: center;
padding: @component-padding/4;
padding: (@component-padding/4);
margin-right: @component-padding;

&:focus-within {
Expand Down Expand Up @@ -271,13 +271,13 @@

&Heading {
display: inline-block;
margin-right: @component-padding*2;
margin-right: (@component-padding*2);
}

&Option {
display: inline-flex;
align-items: center;
padding: @component-padding/4;
padding: (@component-padding/4);
margin-right: @component-padding;

&:focus-within {
Expand All @@ -286,8 +286,8 @@
}

span::before {
margin-left: @component-padding/2;
margin-right: @component-padding/2;
margin-left: (@component-padding/2);
margin-right: (@component-padding/2);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion styles/dock.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ atom-dock.right .github-IssueishDetailView {


&-tablist { flex-wrap: wrap; }
&-tab { padding: @component-padding/2 @component-padding; }
&-tab { padding: (@component-padding/2) @component-padding; }
&-tab-icon { display: none; }


Expand Down
6 changes: 3 additions & 3 deletions styles/editor-comment.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ atom-text-editor {
&.react-atom-decoration {
width: 100%;
text-align: center;
padding: 0 @component-padding/4;
padding: 0 (@component-padding/4);
}

button {
Expand All @@ -44,14 +44,14 @@ atom-text-editor {
background-color: @tool-panel-background-color;
border-radius: @component-border-radius;
padding: @component-padding;
margin: @component-padding/2 0;
margin: (@component-padding/2) 0;

p {
display: flex;
flex-direction: row;
justify-content: center;
align-items: center;
margin: @component-padding/4;
margin: (@component-padding/4);
}

button {
Expand Down
10 changes: 5 additions & 5 deletions styles/file-patch-list-view.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
position: relative;
display: flex;
align-items: flex-start;
padding: @component-padding/2 @component-padding;
padding-left: @component-padding * 3.5;
padding: (@component-padding/2) @component-padding;
padding-left: (@component-padding * 3.5);
overflow: hidden;
-webkit-user-select: none;
cursor: default;
Expand All @@ -24,7 +24,7 @@
&-icon {
text-align: right;
&:before {
margin-right: @component-padding / 1.2;
margin-right: (@component-padding / 1.2);
}
}

Expand All @@ -35,10 +35,10 @@

&-resolutionItem {
padding-top: 0;
padding-bottom: @component-padding / 2;
padding-bottom: (@component-padding / 2);
}
}

.github-MergeConflictPaths .github-FilePatchListView-icon:last-child {
margin-left: @component-padding / 2;
margin-left: (@component-padding / 2);
}
6 changes: 3 additions & 3 deletions styles/file-patch-view.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
}

.btn-group {
margin: @component-padding/2;
margin: (@component-padding/2);
}
}

Expand Down Expand Up @@ -95,7 +95,7 @@
&-collapseButton {
background: transparent;
border: none;
padding: @component-padding/1.5;
padding: (@component-padding/1.5);

& + .github-FilePatchView-title {
margin-left: 0; // chevron already has margin
Expand Down Expand Up @@ -207,7 +207,7 @@
}
&--fullWidth {
display: block;
margin: @component-padding/2 0 0 0;
margin: (@component-padding/2) 0 0 0;
&:first-child {
margin-top: 0;
}
Expand Down
6 changes: 3 additions & 3 deletions styles/git-identity.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
}

&-explanation {
margin-bottom: @component-padding * 3;
margin-bottom: (@component-padding * 3);
}

&-text {
width: 90%;
margin-bottom: @component-padding * 2;
margin-bottom: (@component-padding * 2);

.github-AtomTextEditor-container {
margin: @component-padding 0;
Expand All @@ -27,7 +27,7 @@

&-buttons {
.btn {
margin: @component-padding/2;
margin: (@component-padding/2);
}
}
}
6 changes: 3 additions & 3 deletions styles/git-tab.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,15 @@
display: flex;
justify-content: center;
font-size: 1.25em;
padding: @component-padding * 3;
padding: (@component-padding * 3);
text-align: center;

> * {
margin: @component-padding 0;
}

h1 {
margin-bottom: @component-padding * 3;
margin-bottom: (@component-padding * 3);
}

button {
Expand All @@ -46,7 +46,7 @@

&-LargeIcon:before {
margin-right: 0;
margin-bottom: @component-padding * 5;
margin-bottom: (@component-padding * 5);
width: auto;
height: auto;
font-size: 8em;
Expand Down
Loading