-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add timeout option to interactive confirm printer. #568
base: master
Are you sure you want to change the base?
Feature: Add timeout option to interactive confirm printer. #568
Conversation
Hi @KarolosLykos, looks good so far! The only thing is, that it's not visible, that the ConfirmPrinter will automatically choose a value, after a given time. Could you add a countdown to the output, that only shows if Timeout > 0? Where the This could be solved by using an area, but I would recommend a Also, normally this shows, when a user chooses a value: I think we could show something like that, when the timeout is reached: |
Yes, that make sense. To ensure I grasp your point correctly, you're suggesting refactoring the |
@MarvinJWendt Hi, I've made the requested changes, but I'm encountering issues with passing the checks, especially on the Windows platform. I'm currently using Arch Linux and lack access to a Windows machine. Could you please review the changes and provide feedback? Additionally, could you advise on what needs to be modified for the Windows platform tests, as they seem to hang on tests I didn't modify? |
Hi @KarolosLykos, I will look into it. Weird that windows times out. |
Hi @KarolosLykos, I spent some time trying to find the bug here. I guess that some keyboard event is pushed and never read, meaning that all following events are out of sync (which would explain the next tests to fail). We want to rewrite the whole testing system in the future anyway, so I think you can remove the tests that you introduced for this printer. In the future, we want to test all printers separately. |
…ws compatibility issues in CI/CD
…ws compatibility issues in CI/CD
Description
Added a timeout feature to the interactive confirm printer. Now, if a timeout is specified and no answer is provided, the default value is automatically selected. This enhancement improves the user experience by allowing the confirmation prompt to automatically proceed with the default choice when a response isn't provided within the defined timeframe.
Scope
interactive_confirm_printer
Related Issue
Fixes #543
To-Do Checklist